From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116127 invoked by alias); 21 Feb 2019 15:14:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116109 invoked by uid 89); 21 Feb 2019 15:14:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=widespread, Hx-languages-length:616, treating X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Feb 2019 15:14:46 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwq3g-0007UR-G3; Thu, 21 Feb 2019 10:14:44 -0500 Received: from [176.228.60.248] (port=3977 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gwq3g-0002nk-3Y; Thu, 21 Feb 2019 10:14:44 -0500 Date: Thu, 21 Feb 2019 15:14:00 -0000 Message-Id: <83sgwhfa1o.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20190221140513.29508-1-tromey@adacore.com> (message from Tom Tromey on Thu, 21 Feb 2019 07:05:13 -0700) Subject: Re: [PATCH] Handle \r\n in gdbreplay References: <20190221140513.29508-1-tromey@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00348.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Thu, 21 Feb 2019 07:05:13 -0700 > > I tried gdbreplay yesterday, but the remotelogfile I received was made > on Windows, so the lines were terminated with \r\n rather than plain > \n. > > This patch changes gdbreplay to allow \r or \r\n line termination when > reading the log file. I'm okay with treating \r\n as a single \n, but do we really want to treat a single \r as if it were \n? I thought systems which used that EOL convention are not really widespread, to say the least. Thanks.