Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Give a name to the TUI SingleKey keymap
Date: Wed, 11 Sep 2019 02:39:00 -0000	[thread overview]
Message-ID: <83sgp31rpq.fsf@gnu.org> (raw)
In-Reply-To: <20190911004352.24819-1-tom@tromey.com> (message from Tom Tromey	on Tue, 10 Sep 2019 18:43:52 -0600)

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Tue, 10 Sep 2019 18:43:52 -0600
> 
> Readline 8.0 has a feature that lets an application name a keymap.
> This in turn makes it simpler for users to bind keys in keymaps in
> their .inputrc.
> 
> This patch gives a name to the TUI SingleKey keymap, so that
> additional bindings can be made there.  For example:
> 
>     $if gdb
>     set keymap SingleKey
>     "X": "echo hello\\n\n"
>     $endif
> 
> The call to rl_initialize, in tui_initialize_readline, had to be
> removed so that .inputrc was not read too early.  Note that Readline
> explicitly documents that this call is not needed.

The documentation part is OK, but please add index entries to the new
information, so that it could be easily found if someone forgets the
details.

Also, should this be in NEWS?

Thanks.


  reply	other threads:[~2019-09-11  2:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  0:44 Tom Tromey
2019-09-11  2:39 ` Eli Zaretskii [this message]
2019-09-17 21:23   ` Tom Tromey
2019-09-18  2:37     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sgp31rpq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox