From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39617 invoked by alias); 11 Sep 2019 02:39:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39608 invoked by uid 89); 11 Sep 2019 02:39:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=documents X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 02:39:38 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i7sXh-0005jn-4H; Tue, 10 Sep 2019 22:39:37 -0400 Received: from [176.228.60.248] (port=3901 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i7sXg-0001wR-Jp; Tue, 10 Sep 2019 22:39:36 -0400 Date: Wed, 11 Sep 2019 02:39:00 -0000 Message-Id: <83sgp31rpq.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20190911004352.24819-1-tom@tromey.com> (message from Tom Tromey on Tue, 10 Sep 2019 18:43:52 -0600) Subject: Re: [PATCH] Give a name to the TUI SingleKey keymap References: <20190911004352.24819-1-tom@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00197.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Tue, 10 Sep 2019 18:43:52 -0600 > > Readline 8.0 has a feature that lets an application name a keymap. > This in turn makes it simpler for users to bind keys in keymaps in > their .inputrc. > > This patch gives a name to the TUI SingleKey keymap, so that > additional bindings can be made there. For example: > > $if gdb > set keymap SingleKey > "X": "echo hello\\n\n" > $endif > > The call to rl_initialize, in tui_initialize_readline, had to be > removed so that .inputrc was not read too early. Note that Readline > explicitly documents that this call is not needed. The documentation part is OK, but please add index entries to the new information, so that it could be easily found if someone forgets the details. Also, should this be in NEWS? Thanks.