From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Don't define _FORTIFY_SOURCE on mingw
Date: Wed, 08 Jan 2020 03:30:00 -0000 [thread overview]
Message-ID: <83sgkqbp68.fsf@gnu.org> (raw)
In-Reply-To: <CAPTJ0XF91qwr6aFLZLrQ0shwws-0sCOOdr3sMyKQL-aS6zfWYQ@mail.gmail.com> (gdb-patches@sourceware.org)
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Date: Tue, 7 Jan 2020 17:42:55 -0600
> Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
>
> > I was also thinking of adding a NEWS entry. However, IIUC, this option
> > had no effect with previous versions of MinGW? Thus, in the end,
> > this patch makes the situation stay the same regardless of MinGW
> > version, meaning no NEWS updated needed.
>
> My understanding is that this did use to work (maybe it automatically
> linked against -lssp?). But I'm not sure a NEWS entry is needed? This
> does not seem user-visible.
I think it used to work because the MinGW GCC wasn't reacting to
_FORTIFY_SOURCE, so it was largely a no-op for MinGW. This changed in
a recent version of MinGW GCC.
I'm also not sure this should be in NEWS. It depends on how MinGW
users who build GDB are sensitive to _FORTIFY_SOURCE.
next prev parent reply other threads:[~2020-01-08 3:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 18:14 [PATCH] Link to -lssp when available (fixes mingw build) Christian Biesinger via gdb-patches
2019-12-18 18:23 ` Christian Biesinger via gdb-patches
2019-12-18 18:45 ` Eli Zaretskii
2019-12-18 18:57 ` Christian Biesinger via gdb-patches
2019-12-18 19:07 ` [PATCH v2] Don't define _FORTIFY_SOURCE on mingw Christian Biesinger via gdb-patches
2020-01-02 11:31 ` Joel Brobecker
2020-01-07 23:43 ` Christian Biesinger via gdb-patches
2020-01-08 3:30 ` Eli Zaretskii [this message]
2020-01-09 22:23 ` Tom Tromey
2020-01-09 22:32 ` Christian Biesinger via gdb-patches
2020-01-10 0:28 ` Tom Tromey
2019-12-18 19:08 ` [PATCH] Link to -lssp when available (fixes mingw build) Eli Zaretskii
2019-12-18 19:12 ` Christian Biesinger via gdb-patches
2019-12-18 19:40 ` Eli Zaretskii
2019-12-18 19:50 ` Christian Biesinger via gdb-patches
2019-12-18 19:57 ` Eli Zaretskii
2019-12-18 20:41 ` Christian Biesinger via gdb-patches
2019-12-18 23:12 ` Eli Zaretskii
2019-12-18 23:24 ` Christian Biesinger via gdb-patches
2019-12-19 14:19 ` Pedro Alves
2019-12-19 15:49 ` Eli Zaretskii
2020-02-15 14:06 ` Eli Zaretskii
2019-12-19 20:41 ` Christian Biesinger via gdb-patches
2019-12-19 15:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgkqbp68.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox