From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17530 invoked by alias); 8 Jan 2020 03:30:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17461 invoked by uid 89); 8 Jan 2020 03:30:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:sk:RSA_AES X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jan 2020 03:30:22 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ip232-0001KO-C1; Tue, 07 Jan 2020 22:30:20 -0500 Received: from [176.228.60.248] (port=3621 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ip22s-00066a-2e; Tue, 07 Jan 2020 22:30:16 -0500 Date: Wed, 08 Jan 2020 03:30:00 -0000 Message-Id: <83sgkqbp68.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: (gdb-patches@sourceware.org) Subject: Re: [PATCH v2] Don't define _FORTIFY_SOURCE on mingw References: <20191218190705.161582-1-cbiesinger@google.com> <20200102113102.GA4137@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00172.txt.bz2 > From: "Christian Biesinger via gdb-patches" > Date: Tue, 7 Jan 2020 17:42:55 -0600 > Cc: Christian Biesinger via gdb-patches > > > I was also thinking of adding a NEWS entry. However, IIUC, this option > > had no effect with previous versions of MinGW? Thus, in the end, > > this patch makes the situation stay the same regardless of MinGW > > version, meaning no NEWS updated needed. > > My understanding is that this did use to work (maybe it automatically > linked against -lssp?). But I'm not sure a NEWS entry is needed? This > does not seem user-visible. I think it used to work because the MinGW GCC wasn't reacting to _FORTIFY_SOURCE, so it was largely a no-op for MinGW. This changed in a recent version of MinGW GCC. I'm also not sure this should be in NEWS. It depends on how MinGW users who build GDB are sensitive to _FORTIFY_SOURCE.