From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] Fix struct sockaddr/sockaddr_in/sockaddr_un strict aliasing violations
Date: Mon, 09 Mar 2015 16:04:00 -0000 [thread overview]
Message-ID: <83r3sy5f8m.fsf@gnu.org> (raw)
In-Reply-To: <54FD864D.8030403@redhat.com>
> Date: Mon, 09 Mar 2015 11:38:53 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> On 03/09/2015 11:10 AM, Pedro Alves wrote:
>
> > With all that said, I'm having second thoughts on this ... Per
> > 6.3.2.3 ("A pointer to an object or incomplete type may be converted to
> > a pointer to a different object or incomplete type"), as long as we don't
> > actually access the fields of sockaddr through the "struct sockaddr *" pointer,
> > then the cast should be OK. In the bind/accept cast, it should be the
> > internals of those functions that need the union trick. Gosh, what a mess.
> >
> > So I'll revert the union patch, and apply the original one that added
> > the missing cast to tracepoint.c...
>
> Done. Sorry for the noise...
I should be sorry first ;-)
prev parent reply other threads:[~2015-03-09 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 17:44 Pedro Alves
2015-03-07 18:00 ` Eli Zaretskii
2015-03-07 18:20 ` Pedro Alves
2015-03-07 18:53 ` Eli Zaretskii
2015-03-09 10:45 ` Pedro Alves
2015-03-09 11:10 ` Pedro Alves
2015-03-09 11:38 ` Pedro Alves
2015-03-09 16:04 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r3sy5f8m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox