From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29757 invoked by alias); 9 Mar 2015 16:04:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29747 invoked by uid 89); 9 Mar 2015 16:04:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout27.012.net.il Received: from mtaout27.012.net.il (HELO mtaout27.012.net.il) (80.179.55.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Mar 2015 16:04:57 +0000 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NKY00400C2VZS00@mtaout27.012.net.il> for gdb-patches@sourceware.org; Mon, 09 Mar 2015 17:59:30 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKY00JOKCF6SQB0@mtaout27.012.net.il>; Mon, 09 Mar 2015 17:59:30 +0200 (IST) Date: Mon, 09 Mar 2015 16:04:00 -0000 From: Eli Zaretskii Subject: Re: [pushed] Fix struct sockaddr/sockaddr_in/sockaddr_un strict aliasing violations In-reply-to: <54FD864D.8030403@redhat.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83r3sy5f8m.fsf@gnu.org> References: <1425750266-14385-1-git-send-email-palves@redhat.com> <83r3t0lmb9.fsf@gnu.org> <54FB4162.5090601@redhat.com> <83oao4ljwg.fsf@gnu.org> <54FD79B4.8070201@redhat.com> <54FD7F9D.9070809@redhat.com> <54FD864D.8030403@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00223.txt.bz2 > Date: Mon, 09 Mar 2015 11:38:53 +0000 > From: Pedro Alves > CC: gdb-patches@sourceware.org > > On 03/09/2015 11:10 AM, Pedro Alves wrote: > > > With all that said, I'm having second thoughts on this ... Per > > 6.3.2.3 ("A pointer to an object or incomplete type may be converted to > > a pointer to a different object or incomplete type"), as long as we don't > > actually access the fields of sockaddr through the "struct sockaddr *" pointer, > > then the cast should be OK. In the bind/accept cast, it should be the > > internals of those functions that need the union trick. Gosh, what a mess. > > > > So I'll revert the union patch, and apply the original one that added > > the missing cast to tracepoint.c... > > Done. Sorry for the noise... I should be sorry first ;-)