From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 7/8] Add $_ada_exception convenience variable
Date: Thu, 01 Aug 2019 17:56:00 -0000 [thread overview]
Message-ID: <83r264his1.fsf@gnu.org> (raw)
In-Reply-To: <20190801170412.5553-8-tromey@adacore.com> (message from Tom Tromey on Thu, 1 Aug 2019 11:04:11 -0600)
> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>
> Date: Thu, 1 Aug 2019 11:04:11 -0600
>
> This adds the $_ada_exception convenience variable. It is set by the
> Ada exception catchpoints, and holds the address of the exception
> currently being thrown. This is useful because it allows more
> fine-grained filtering of exceptions than is possible using the
> existing "catch" syntax.
>
> This also simplifies Ada catchpoints somewhat; because the catchpoint
> must now carry the "kind", it's possible to remove many helper
> functions.
>
> 2019-08-01 Tom Tromey <tromey@adacore.com>
>
> * NEWS: Add $_ada_exception entry.
> * ada-lang.c (struct ada_catchpoint): Add constructor.
> <m_kind>: New member.
> (allocate_location_exception, re_set_exception): Remove
> "ex" parameter.
> (should_stop_exception): Compute $_ada_exception.
> (check_status_exception, print_it_exception)
> (print_one_exception, print_mention_exception): Remove
> "ex" parameter.
> (allocate_location_catch_exception, re_set_catch_exception)
> (check_status_exception, print_it_catch_exception)
> (print_one_catch_exception, print_mention_catch_exception)
> (print_recreate_catch_exception)
> (allocate_location_catch_exception_unhandled)
> (re_set_catch_exception_unhandled)
> (check_status_exception, print_it_catch_exception_unhandled)
> (print_one_catch_exception_unhandled)
> (print_mention_catch_exception_unhandled)
> (print_recreate_catch_exception_unhandled)
> (allocate_location_catch_assert, re_set_catch_assert)
> (check_status_assert, print_it_catch_assert)
> (print_one_catch_assert, print_mention_catch_assert)
> (print_recreate_catch_assert)
> (allocate_location_catch_handlers, re_set_catch_handlers)
> (check_status_handlers, print_it_catch_handlers)
> (print_one_catch_handlers, print_mention_catch_handlers)
> (print_recreate_catch_handlers): Remove.
> (create_ada_exception_catchpoint): Update.
> (initialize_ada_catchpoint_ops): Update.
>
> gdb/doc/ChangeLog
> 2019-08-01 Tom Tromey <tromey@adacore.com>
>
> * gdb.texinfo (Set Catchpoints, Convenience Vars): Document
> $_ada_exception.
>
> gdb/testsuite/ChangeLog
> 2019-08-01 Tom Tromey <tromey@adacore.com>
>
> * gdb.ada/catch_ex_std.exp: Add $_ada_exception test.
Thanks. The documentation parts are approved, but I wonder whether we
should index this new variable, as others are indexed.
next prev parent reply other threads:[~2019-08-01 17:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 17:04 [PATCH v2 0/8] Handle copy relocations and add $_ada_exception Tom Tromey
2019-08-01 17:04 ` [PATCH v2 7/8] Add $_ada_exception convenience variable Tom Tromey
2019-08-01 17:56 ` Eli Zaretskii [this message]
2019-09-20 19:16 ` Tom Tromey
2019-08-27 9:47 ` Andrew Burgess
2019-09-20 19:15 ` Tom Tromey
2019-08-01 17:04 ` [PATCH v2 6/8] Make current_source_* per-program-space Tom Tromey
2019-08-20 15:57 ` Andrew Burgess
2019-08-21 19:05 ` Tom Tromey
2019-08-01 17:04 ` [PATCH v2 3/8] Back out earlier Ada exception change Tom Tromey
2019-08-01 17:04 ` [PATCH v2 2/8] Handle copy relocations Tom Tromey
2019-08-21 15:35 ` Andrew Burgess
2019-08-21 19:11 ` Tom Tromey
2019-08-22 8:41 ` Andrew Burgess
2019-09-19 17:45 ` Tom Tromey
2019-09-19 18:28 ` Tom Tromey
2019-09-19 18:40 ` Andrew Burgess
2019-08-01 17:04 ` [PATCH v2 8/8] Make print-file-var.exp test attribute visibility hidden, dlopen, and main symbol Tom Tromey
2019-08-20 13:41 ` Andrew Burgess
2019-08-21 14:35 ` Andrew Burgess
2019-08-01 17:04 ` [PATCH v2 1/8] Change SYMBOL_VALUE_ADDRESS to be an rvalue Tom Tromey
2019-08-01 17:12 ` [PATCH v2 4/8] Search global block from basic_lookup_symbol_nonlocal Tom Tromey
2019-08-21 10:32 ` Andrew Burgess
2019-08-27 9:54 ` Andrew Burgess
2019-08-27 18:17 ` Christian Biesinger via gdb-patches
2019-08-28 12:34 ` Andrew Burgess
2019-08-01 17:12 ` [PATCH v2 5/8] Don't call decode_line_with_current_source from select_source_symtab Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r264his1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox