From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53677 invoked by alias); 1 Aug 2019 17:56:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53669 invoked by uid 89); 1 Aug 2019 17:56:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Aug 2019 17:56:17 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1htFJ7-0008H3-RV; Thu, 01 Aug 2019 13:56:07 -0400 Received: from [176.228.60.248] (port=3276 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1htFJ6-0000lG-4u; Thu, 01 Aug 2019 13:56:05 -0400 Date: Thu, 01 Aug 2019 17:56:00 -0000 Message-Id: <83r264his1.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20190801170412.5553-8-tromey@adacore.com> (message from Tom Tromey on Thu, 1 Aug 2019 11:04:11 -0600) Subject: Re: [PATCH v2 7/8] Add $_ada_exception convenience variable References: <20190801170412.5553-1-tromey@adacore.com> <20190801170412.5553-8-tromey@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00026.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Thu, 1 Aug 2019 11:04:11 -0600 > > This adds the $_ada_exception convenience variable. It is set by the > Ada exception catchpoints, and holds the address of the exception > currently being thrown. This is useful because it allows more > fine-grained filtering of exceptions than is possible using the > existing "catch" syntax. > > This also simplifies Ada catchpoints somewhat; because the catchpoint > must now carry the "kind", it's possible to remove many helper > functions. > > 2019-08-01 Tom Tromey > > * NEWS: Add $_ada_exception entry. > * ada-lang.c (struct ada_catchpoint): Add constructor. > : New member. > (allocate_location_exception, re_set_exception): Remove > "ex" parameter. > (should_stop_exception): Compute $_ada_exception. > (check_status_exception, print_it_exception) > (print_one_exception, print_mention_exception): Remove > "ex" parameter. > (allocate_location_catch_exception, re_set_catch_exception) > (check_status_exception, print_it_catch_exception) > (print_one_catch_exception, print_mention_catch_exception) > (print_recreate_catch_exception) > (allocate_location_catch_exception_unhandled) > (re_set_catch_exception_unhandled) > (check_status_exception, print_it_catch_exception_unhandled) > (print_one_catch_exception_unhandled) > (print_mention_catch_exception_unhandled) > (print_recreate_catch_exception_unhandled) > (allocate_location_catch_assert, re_set_catch_assert) > (check_status_assert, print_it_catch_assert) > (print_one_catch_assert, print_mention_catch_assert) > (print_recreate_catch_assert) > (allocate_location_catch_handlers, re_set_catch_handlers) > (check_status_handlers, print_it_catch_handlers) > (print_one_catch_handlers, print_mention_catch_handlers) > (print_recreate_catch_handlers): Remove. > (create_ada_exception_catchpoint): Update. > (initialize_ada_catchpoint_ops): Update. > > gdb/doc/ChangeLog > 2019-08-01 Tom Tromey > > * gdb.texinfo (Set Catchpoints, Convenience Vars): Document > $_ada_exception. > > gdb/testsuite/ChangeLog > 2019-08-01 Tom Tromey > > * gdb.ada/catch_ex_std.exp: Add $_ada_exception test. Thanks. The documentation parts are approved, but I wonder whether we should index this new variable, as others are indexed.