Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Python pretty-printing [5/6]
Date: Thu, 09 Apr 2009 07:40:00 -0000	[thread overview]
Message-ID: <83prfm46rv.fsf@gnu.org> (raw)
In-Reply-To: <m3iqlews5z.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Date: Wed, 08 Apr 2009 19:07:52 -0600
> 
> Here is the new version of this patch.
> 
> I think I have addressed all the comments; either by making the
> requested change or explaining why I did not.  Still, you probably
> should check.

Thanks.  I have 2 minor comments:

> +We recommend that you put your core pretty-printers into a Python
> +package.  If your pretty-printers are for use with a library, we
> +further recommend embedding a version number into the package name.
> +This practice will enable @value{GDBN} to load multiple versions of
> +your pretty-printers at the same time.

I couldn't quite understand the importance of the version numbers, and
how that would allow GDB to have multiple versions of the same
pretty-printer.  I asked myself how the ``right'' version will be
selected in that case.  Is the way this works documented somewhere
else? if so, a cross-reference here would be good.  If not, I think we
need to say a few words about that.

> +You should write auto-loaded code such that it can be evaluated
> +multiple times without changing its meaning.

Here, I suggest a cross-reference to where auto-loading is described.

Otherwise, this patch for the manual is fine with me.


  reply	other threads:[~2009-04-09  7:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02 20:57 Tom Tromey
2009-04-03 15:29 ` Eli Zaretskii
2009-04-09  0:29   ` Tom Tromey
2009-04-04 16:39 ` Thiago Jung Bauermann
2009-04-09  0:52   ` Tom Tromey
2009-04-09 15:00     ` Thiago Jung Bauermann
2009-04-09 15:19       ` Phil Muldoon
2009-04-09 15:41         ` Thiago Jung Bauermann
2009-04-09 16:18           ` Tom Tromey
2009-04-09 15:44       ` Tom Tromey
2009-04-09 19:37     ` Tom Tromey
2009-04-09 22:09       ` Thiago Jung Bauermann
2009-04-09 22:36         ` Tom Tromey
2009-04-07 18:32 ` Joel Brobecker
2009-04-07 18:41   ` Tom Tromey
2009-04-07 20:38     ` Joel Brobecker
2009-04-09  1:08 ` Tom Tromey
2009-04-09  7:40   ` Eli Zaretskii [this message]
2009-04-09 16:16     ` Tom Tromey
2009-04-09 16:41       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83prfm46rv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox