From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25171 invoked by alias); 9 Apr 2009 07:40:08 -0000 Received: (qmail 25162 invoked by uid 22791); 9 Apr 2009 07:40:07 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Apr 2009 07:40:00 +0000 Received: from conversion-daemon.i-mtaout7.012.net.il by i-mtaout7.012.net.il (HyperSendmail v2007.08) id <0KHT00400P71ZJ00@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Thu, 09 Apr 2009 10:39:23 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.70.19]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KHT002NUP9MTF00@i-mtaout7.012.net.il>; Thu, 09 Apr 2009 10:39:22 +0300 (IDT) Date: Thu, 09 Apr 2009 07:40:00 -0000 From: Eli Zaretskii Subject: Re: Python pretty-printing [5/6] In-reply-to: To: Tom Tromey Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83prfm46rv.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00171.txt.bz2 > From: Tom Tromey > Date: Wed, 08 Apr 2009 19:07:52 -0600 > > Here is the new version of this patch. > > I think I have addressed all the comments; either by making the > requested change or explaining why I did not. Still, you probably > should check. Thanks. I have 2 minor comments: > +We recommend that you put your core pretty-printers into a Python > +package. If your pretty-printers are for use with a library, we > +further recommend embedding a version number into the package name. > +This practice will enable @value{GDBN} to load multiple versions of > +your pretty-printers at the same time. I couldn't quite understand the importance of the version numbers, and how that would allow GDB to have multiple versions of the same pretty-printer. I asked myself how the ``right'' version will be selected in that case. Is the way this works documented somewhere else? if so, a cross-reference here would be good. If not, I think we need to say a few words about that. > +You should write auto-loaded code such that it can be evaluated > +multiple times without changing its meaning. Here, I suggest a cross-reference to where auto-loading is described. Otherwise, this patch for the manual is fine with me.