Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 1/3] catch syscall -- try 6 -- Source-code modifications
Date: Sat, 05 Sep 2009 07:20:00 -0000	[thread overview]
Message-ID: <83pra5506w.fsf@gnu.org> (raw)
In-Reply-To: <200909041600.47670.sergiodj@linux.vnet.ibm.com>

> From: Sérgio_Durigan_Júnior <sergiodj@linux.vnet.ibm.com>
> Date: Fri, 4 Sep 2009 16:00:47 -0300
> 
> +  add_catch_command ("syscall", _("\
> +Catch system calls.\n\
> +The program can take one or more arguments (syscalls names\n\

You meant "The command", right?

> +and/or numbers), in which case it will catch the syscalls\n\
> +provided.  It can also take no arguments, in which case it\n\
> +will catch every syscall.\n\
> +The argument(s) should be the syscall name(s) (if your system\n\
> +has support for it), or the syscall number(s).  If you need\n\
> +more information, please refer to GDB manual."),

This is okay, but too wordy at times.  Suggest the following variant
instead:

    Catch system calls by their names and/or numbers.\n\
    Arguments say which system calls to catch.  If no arguments\n\
    are given, every system call will be caught.\n\
    Arguments, if given, should be one or more system call names\n\
    if your system supports that), or system call numbers."),



My only other comment about the code part is that it would be nice to
have somewhere a description of what a target should do to add support
for this feature.


  reply	other threads:[~2009-09-05  7:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04 19:01 Sérgio Durigan Júnior
2009-09-05  7:20 ` Eli Zaretskii [this message]
2009-09-05  7:24 ` Eli Zaretskii
2009-09-10 22:42   ` Sérgio Durigan Júnior
2009-09-11  8:09     ` Eli Zaretskii
2009-09-12  0:28       ` Sérgio Durigan Júnior
2009-09-12  8:20         ` Eli Zaretskii
2009-09-12 17:15           ` Sérgio Durigan Júnior
2009-09-13 17:18             ` Sérgio Durigan Júnior
2009-09-15  3:55               ` Sérgio Durigan Júnior
2009-09-15  4:13                 ` Joel Brobecker
2009-09-15  4:30                   ` Sérgio Durigan Júnior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pra5506w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox