From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28849 invoked by alias); 5 Sep 2009 07:20:39 -0000 Received: (qmail 28840 invoked by uid 22791); 5 Sep 2009 07:20:38 -0000 X-SWARE-Spam-Status: No, hits=-0.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout2.012.net.il (HELO mtaout2.012.net.il) (84.95.2.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Sep 2009 07:20:32 +0000 Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KPH00100LKHS500@i_mtaout2.012.net.il> for gdb-patches@sourceware.org; Sat, 05 Sep 2009 10:20:29 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.50.163]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KPH00MIHLQ46P30@i_mtaout2.012.net.il>; Sat, 05 Sep 2009 10:20:29 +0300 (IDT) Date: Sat, 05 Sep 2009 07:20:00 -0000 From: Eli Zaretskii Subject: Re: [RFC 1/3] catch syscall -- try 6 -- Source-code modifications In-reply-to: <200909041600.47670.sergiodj@linux.vnet.ibm.com> To: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83pra5506w.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 8BIT References: <200909041600.47670.sergiodj@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00113.txt.bz2 > From: Sérgio_Durigan_Júnior > Date: Fri, 4 Sep 2009 16:00:47 -0300 > > + add_catch_command ("syscall", _("\ > +Catch system calls.\n\ > +The program can take one or more arguments (syscalls names\n\ You meant "The command", right? > +and/or numbers), in which case it will catch the syscalls\n\ > +provided. It can also take no arguments, in which case it\n\ > +will catch every syscall.\n\ > +The argument(s) should be the syscall name(s) (if your system\n\ > +has support for it), or the syscall number(s). If you need\n\ > +more information, please refer to GDB manual."), This is okay, but too wordy at times. Suggest the following variant instead: Catch system calls by their names and/or numbers.\n\ Arguments say which system calls to catch. If no arguments\n\ are given, every system call will be caught.\n\ Arguments, if given, should be one or more system call names\n\ if your system supports that), or system call numbers."), My only other comment about the code part is that it would be nice to have somewhere a description of what a target should do to add support for this feature.