From: Eli Zaretskii <eliz@gnu.org>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Implement completion limiting
Date: Wed, 12 Feb 2014 16:27:00 -0000 [thread overview]
Message-ID: <83ppmss3dy.fsf@gnu.org> (raw)
In-Reply-To: <20140212115759.GC2866@blade.nx>
> Date: Wed, 12 Feb 2014 11:57:59 +0000
> From: Gary Benson <gbenson@redhat.com>
>
> This patch adds a new exception, TOO_MANY_COMPLETIONS_ERROR, to be
> thrown whenever the completer has generated too many possibilities to
> be useful. A new user-settable variable, "max_completions", is added
> to control this behaviour.
Thanks.
> +void
> +_initialize_completer (void)
> +{
> + add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class,
> + &max_completions, _("\
> +Set maximum number of line completion possibilities."), _("\
> +Show maximum number of line completion possibilities."), _("\
> +Use this to limit the number of possibilities considered\n\
> +during line completion. Specifying \"unlimited\" or -1\n\
> +disables limiting. Note that setting either no limit or\n\
> +a very large limit can cause pauses during completion."),
Why do you use "line completion"? I think it can only confuse users.
How about
Set maximum number of completion candidates to show.
instead?
Other than that, OK for the documentation part, but please also
provide a NEWS entry for this new functionality.
next prev parent reply other threads:[~2014-02-12 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 11:55 [PATCH 0/2] Limit tab-completion result when list is large Gary Benson
2014-02-12 11:56 ` [PATCH 1/2] Add expansion_notify callback to expand_symtabs_matching Gary Benson
2014-02-12 20:10 ` Tom Tromey
2014-02-12 11:58 ` [PATCH 2/2] Implement completion limiting Gary Benson
2014-02-12 16:27 ` Eli Zaretskii [this message]
2014-02-12 16:41 ` Pedro Alves
2014-02-12 20:53 ` Gary Benson
2014-02-12 21:41 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ppmss3dy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox