From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-110317-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23662 invoked by alias); 12 Feb 2014 16:27:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23652 invoked by uid 89); 12 Feb 2014 16:27:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout26.012.net.il
Received: from mtaout26.012.net.il (HELO mtaout26.012.net.il) (80.179.55.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2014 16:27:16 +0000
Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N0W001005E6G200@mtaout26.012.net.il> for gdb-patches@sourceware.org; Wed, 12 Feb 2014 18:25:50 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N0W00O2F5N1Z630@mtaout26.012.net.il>; Wed, 12 Feb 2014 18:25:50 +0200 (IST)
Date: Wed, 12 Feb 2014 16:27:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 2/2] Implement completion limiting
In-reply-to: <20140212115759.GC2866@blade.nx>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ppmss3dy.fsf@gnu.org>
References: <20140212115548.GA2866@blade.nx> <20140212115759.GC2866@blade.nx>
X-IsSubscribed: yes
X-SW-Source: 2014-02/txt/msg00416.txt.bz2

> Date: Wed, 12 Feb 2014 11:57:59 +0000
> From: Gary Benson <gbenson@redhat.com>
> 
> This patch adds a new exception, TOO_MANY_COMPLETIONS_ERROR, to be
> thrown whenever the completer has generated too many possibilities to
> be useful.  A new user-settable variable, "max_completions", is added
> to control this behaviour.

Thanks.

> +void
> +_initialize_completer (void)
> +{
> +  add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class,
> +				       &max_completions, _("\
> +Set maximum number of line completion possibilities."), _("\
> +Show maximum number of line completion possibilities."), _("\
> +Use this to limit the number of possibilities considered\n\
> +during line completion.  Specifying \"unlimited\" or -1\n\
> +disables limiting.  Note that setting either no limit or\n\
> +a very large limit can cause pauses during completion."),

Why do you use "line completion"?  I think it can only confuse users.
How about

  Set maximum number of completion candidates to show.

instead?

Other than that, OK for the documentation part, but please also
provide a NEWS entry for this new functionality.