Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: b7.10110111@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
Date: Sat, 05 Aug 2017 06:29:00 -0000	[thread overview]
Message-ID: <83pocawmr7.fsf@gnu.org> (raw)
In-Reply-To: <1501874838-3067-1-git-send-email-b7.10110111@gmail.com>

> From: b7.10110111@gmail.com
> Cc: Ruslan Kabatsayev <b7.10110111@gmail.com>
> Date: Fri,  4 Aug 2017 22:27:18 +0300
> 
> From: Ruslan Kabatsayev <b7.10110111@gmail.com>
> 
> Currently, "layout asm" is not so useful as "layout src" with Single-Key mode:
> you have to use multi-key commands like "ni" and "si" to do single-stepping.
> This patch adds, in addition to "next" and "step" commands, corresponding
> assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the
> shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively.

The "i" in "nexti" and "ni" stands for "instruction", not "into".

Personally, I'm not sure this is worth it, but then I don't use TUI
frequently enough to have my opinion count.

If the code change is accepted, the documentation review is below.

> gdb/ChangeLog:
> 
> 	* tui/tui.c: Add "nexti" and "stepi" to the tui_commands list
> 	* doc/gdb.texinfo: Document the new shortcuts in Single-Key mode

The ChangeLog entries need to state the function/data structure in
which the change is made (node name for the manual).  Also,
gdb.texinfo has a separate ChangeLog in gdb/doc/.

> +@kindex o @r{(SingleKey TUI key)}
> +@item o
> +nexti. The letter @samp{o} stands for ``step Over''.
        ^^
We leave two spaces between sentences.

Thanks.


  reply	other threads:[~2017-08-05  6:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 19:28 b7.10110111
2017-08-05  6:29 ` Eli Zaretskii [this message]
2017-08-05  6:38   ` Ruslan Kabatsayev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pocawmr7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=b7.10110111@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox