From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50998 invoked by alias); 5 Aug 2017 06:29:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50981 invoked by uid 89); 5 Aug 2017 06:29:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 05 Aug 2017 06:29:46 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddsai-0006L3-QA for gdb-patches@sourceware.org; Sat, 05 Aug 2017 02:29:44 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddsai-0006Kw-Mz; Sat, 05 Aug 2017 02:29:40 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ddsah-0006QU-Ss; Sat, 05 Aug 2017 02:29:40 -0400 Date: Sat, 05 Aug 2017 06:29:00 -0000 Message-Id: <83pocawmr7.fsf@gnu.org> From: Eli Zaretskii To: b7.10110111@gmail.com CC: gdb-patches@sourceware.org In-reply-to: <1501874838-3067-1-git-send-email-b7.10110111@gmail.com> Subject: Re: [PATCH v2] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode Reply-to: Eli Zaretskii References: <1501874838-3067-1-git-send-email-b7.10110111@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00093.txt.bz2 > From: b7.10110111@gmail.com > Cc: Ruslan Kabatsayev > Date: Fri, 4 Aug 2017 22:27:18 +0300 > > From: Ruslan Kabatsayev > > Currently, "layout asm" is not so useful as "layout src" with Single-Key mode: > you have to use multi-key commands like "ni" and "si" to do single-stepping. > This patch adds, in addition to "next" and "step" commands, corresponding > assembly-level ones - "nexti" and "stepi" - to Single-Key mode, with the > shortcuts of "o" (from "step Over") and "i" (from "Step Into") respectively. The "i" in "nexti" and "ni" stands for "instruction", not "into". Personally, I'm not sure this is worth it, but then I don't use TUI frequently enough to have my opinion count. If the code change is accepted, the documentation review is below. > gdb/ChangeLog: > > * tui/tui.c: Add "nexti" and "stepi" to the tui_commands list > * doc/gdb.texinfo: Document the new shortcuts in Single-Key mode The ChangeLog entries need to state the function/data structure in which the change is made (node name for the manual). Also, gdb.texinfo has a separate ChangeLog in gdb/doc/. > +@kindex o @r{(SingleKey TUI key)} > +@item o > +nexti. The letter @samp{o} stands for ``step Over''. ^^ We leave two spaces between sentences. Thanks.