From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function
Date: Wed, 26 Jun 2019 15:37:00 -0000 [thread overview]
Message-ID: <83pnn0jr39.fsf@gnu.org> (raw)
In-Reply-To: <20190625220832.247935-1-cbiesinger@google.com> (gdb-patches@sourceware.org)
> Date: Tue, 25 Jun 2019 17:08:32 -0500
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2cc82e8656..e52af20748 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -36,6 +36,9 @@
> ** gdb.Type has a new property 'objfile' which returns the objfile the
> type was defined in.
>
> + ** gdb.Objfile has a new method 'lookup_global_symbol' to lookup a symbol
> + from this objfile only.
> +
> * New commands
This part is OK.
> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]})
> +Searches for a global symbol by name in this objfile. Optionally, the
^^
Two spaces between sentences (here and elsewhere in the patch),
please.
The documentation part is OK with this nit fixed.
Thanks.
next prev parent reply other threads:[~2019-06-26 15:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 22:09 Christian Biesinger via gdb-patches
2019-06-26 15:37 ` Eli Zaretskii [this message]
2019-06-26 21:05 ` Tom Tromey
2019-06-27 2:36 ` Eli Zaretskii
2019-06-26 15:38 ` Eli Zaretskii
2019-06-26 21:12 ` Tom Tromey
2019-07-08 21:59 ` Christian Biesinger via gdb-patches
2019-07-09 15:42 ` Eli Zaretskii
2019-07-09 18:44 ` Christian Biesinger via gdb-patches
2019-07-09 19:16 ` Eli Zaretskii
2019-07-22 20:51 ` Christian Biesinger via gdb-patches
2019-07-23 1:30 ` Simon Marchi
2019-07-23 14:47 ` Eli Zaretskii
2019-07-26 1:38 ` Christian Biesinger via gdb-patches
2019-07-26 1:38 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-07-26 6:19 ` Eli Zaretskii
2019-07-27 0:31 ` [PATCH v3] Add Objfile.lookup_{global,static}_symbol functions Christian Biesinger via gdb-patches
2019-07-27 7:52 ` Eli Zaretskii
2019-07-27 18:31 ` [PATCH v4] " Christian Biesinger via gdb-patches
2019-07-27 18:38 ` Eli Zaretskii
2019-07-30 1:03 ` Simon Marchi
2019-07-30 1:51 ` [PATCH v5] " Christian Biesinger via gdb-patches
2019-07-30 14:59 ` Eli Zaretskii
2019-07-26 15:40 ` [PATCH] Add an Objfile.lookup_global_symbol function Simon Marchi
2019-07-23 14:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pnn0jr39.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox