From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122822 invoked by alias); 26 Jun 2019 15:37:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122809 invoked by uid 89); 26 Jun 2019 15:37:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jun 2019 15:37:20 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hg9z1-0005pD-Ky; Wed, 26 Jun 2019 11:37:16 -0400 Received: from [176.228.60.248] (port=3993 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hg9yz-0003lj-Bg; Wed, 26 Jun 2019 11:37:13 -0400 Date: Wed, 26 Jun 2019 15:37:00 -0000 Message-Id: <83pnn0jr39.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: gdb-patches@sourceware.org In-reply-to: <20190625220832.247935-1-cbiesinger@google.com> (gdb-patches@sourceware.org) Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function References: <20190625220832.247935-1-cbiesinger@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00597.txt.bz2 > Date: Tue, 25 Jun 2019 17:08:32 -0500 > From: "Christian Biesinger via gdb-patches" > Cc: Christian Biesinger > > diff --git a/gdb/NEWS b/gdb/NEWS > index 2cc82e8656..e52af20748 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -36,6 +36,9 @@ > ** gdb.Type has a new property 'objfile' which returns the objfile the > type was defined in. > > + ** gdb.Objfile has a new method 'lookup_global_symbol' to lookup a symbol > + from this objfile only. > + > * New commands This part is OK. > +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]}) > +Searches for a global symbol by name in this objfile. Optionally, the ^^ Two spaces between sentences (here and elsewhere in the patch), please. The documentation part is OK with this nit fixed. Thanks.