Re: [PATCH] Move [PAC] into a new MI field addr_flags

[Eli Zaretskii <eliz@gnu.org>]

> From: Alan Hayward <Alan.Hayward@arm.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, nd <nd@arm.com>
> Date: Tue, 13 Aug 2019 09:19:26 +0000
> How about this:
> 
> 
> * Other MI changes
> 
>  ** Backtraces and frames include a new optional field addr_flags which is
>     given after the addr field.  On AArch64 this contains PAC if the address
>     has been masked in the frame.  On all other targets the field is not
>     present.

LGTM.

> >> +@item addr_flags
> >> +Optional field containing any flags related to the address.  If there
> >> +are any flags defined for the current target then they are documented in
> >> +the @xref{Architectures} section.
> > 
> > I suggest to reword:
> > 
> >  These flags are architecture-dependent; see @ref{Architectures} for
> >  their meaning for a particular CPU.
> 
> Maybe keep the first sentence? Giving:
> 
> Optional field containing any flags related to the address.  These flags are
> architecture-dependent; see @ref{Architectures} for their meaning for a
> particular CPU.

Yes, I definitely meant to keep the first sentence.

Thanks.