From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71484 invoked by alias); 13 Aug 2019 14:28:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71448 invoked by uid 89); 13 Aug 2019 14:28:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=U*gdb-patches, gdbpatchessourcewareorg, sk:gdb-pat, gdb-patches@sourceware.org X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Aug 2019 14:28:32 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hxXmo-0005US-VN; Tue, 13 Aug 2019 10:28:31 -0400 Received: from [176.228.60.248] (port=1045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hxXmn-0006Ad-B4; Tue, 13 Aug 2019 10:28:30 -0400 Date: Tue, 13 Aug 2019 14:28:00 -0000 Message-Id: <83pnl9rvgd.fsf@gnu.org> From: Eli Zaretskii To: Alan Hayward CC: gdb-patches@sourceware.org, nd@arm.com In-reply-to: <13AF2ADD-7322-420D-A889-FB5BA19CFF99@arm.com> (message from Alan Hayward on Tue, 13 Aug 2019 09:19:26 +0000) Subject: Re: [PATCH] Move [PAC] into a new MI field addr_flags References: <20190812151349.61011-1-alan.hayward@arm.com> <83zhkes8cu.fsf@gnu.org> <13AF2ADD-7322-420D-A889-FB5BA19CFF99@arm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00267.txt.bz2 > From: Alan Hayward > CC: "gdb-patches@sourceware.org" , nd > Date: Tue, 13 Aug 2019 09:19:26 +0000 > How about this: > > > * Other MI changes > > ** Backtraces and frames include a new optional field addr_flags which is > given after the addr field. On AArch64 this contains PAC if the address > has been masked in the frame. On all other targets the field is not > present. LGTM. > >> +@item addr_flags > >> +Optional field containing any flags related to the address. If there > >> +are any flags defined for the current target then they are documented in > >> +the @xref{Architectures} section. > > > > I suggest to reword: > > > > These flags are architecture-dependent; see @ref{Architectures} for > > their meaning for a particular CPU. > > Maybe keep the first sentence? Giving: > > Optional field containing any flags related to the address. These flags are > architecture-dependent; see @ref{Architectures} for their meaning for a > particular CPU. Yes, I definitely meant to keep the first sentence. Thanks.