Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, andrew.burgess@embecosm.com
Subject: Re: [PATCH v2 2/3] gdb: New maintenance command to disable bfd sharing.
Date: Thu, 13 Aug 2015 14:24:00 -0000	[thread overview]
Message-ID: <83oaibnu4x.fsf@gnu.org> (raw)
In-Reply-To: <77dce5f054bd1f7be0f87fe36c5d7e4acdef7c9b.1439454670.git.andrew.burgess@embecosm.com>

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Thu, 13 Aug 2015 13:44:59 +0100
> 
> In some rare maintainer cases it is desirable to be able to disable bfd
> sharing.  This patch adds new commands maintenance set/show commands for
> bfd-sharing, allowing gdb's bfd cache to be turned off.
> 
> gdb/ChangeLog:
> 
> 	* gdb_bfd.c (bfd_sharing): New variable.
> 	(gdb_bfd_open): Check bfd_sharing variable.
> 	(_initialize_gdb_bfd): Add new set/show command.
> 	* NEWS: Mention new command.
> 
> gdb/doc/ChangeLog:
> 
> 	* gdb.texinfo (Maintenance Commands): Move documentation of "main
> 	info bfds" to...
> 	(File Caching): A New section.  Outline bfd caching, and add new
> 	description for "main set/show bfd-sharing".

OK for the documentation parts, with one comment:

> +Control whether @code{bfd} objects can be shared.  When sharing is
> +enabled @value{GDBN} will reuse already open @code{bfd} objects rather
          ^
Please insert a comma where indicated.

Thanks.


  reply	other threads:[~2015-08-13 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 12:45 [PATCH v2 0/3] bfd cache: tighten match criteria and debug commands Andrew Burgess
2015-08-13 12:45 ` [PATCH v2 2/3] gdb: New maintenance command to disable bfd sharing Andrew Burgess
2015-08-13 14:24   ` Eli Zaretskii [this message]
2015-08-17 17:34   ` Pedro Alves
2015-08-13 12:45 ` [PATCH v2 3/3] gdb: Add debug tracing for bfd cache activity Andrew Burgess
2015-08-17 17:34   ` Pedro Alves
2015-08-13 12:45 ` [PATCH v2 1/3] gdb: Improve cache matching criteria for the bfd cache Andrew Burgess
2015-08-17 17:34   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83oaibnu4x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox