From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/3] gdb: Add debug tracing for bfd cache activity.
Date: Mon, 17 Aug 2015 17:34:00 -0000 [thread overview]
Message-ID: <55D21B2D.4090009@redhat.com> (raw)
In-Reply-To: <20978b0a40cbc4fd2a82039f2a36463cb7c6cb83.1439454670.git.andrew.burgess@embecosm.com>
On 08/13/2015 01:45 PM, Andrew Burgess wrote:
> gdb/doc/ChngeLog:
( typo on commit log )
> + add_setshow_zuinteger_cmd ("bfd-cache", class_maintenance,
> + &debug_bfd_cache, _("\
> +Set bfd cache debugging."), _("\
> +Show bfd cache debugging."), _("\
> +When non-zero, bfd cache specific debugging is enabled."),
> + NULL,
> + NULL,
Add show hook, for i18n.
Otherwise LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-08-17 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 12:45 [PATCH v2 0/3] bfd cache: tighten match criteria and debug commands Andrew Burgess
2015-08-13 12:45 ` [PATCH v2 1/3] gdb: Improve cache matching criteria for the bfd cache Andrew Burgess
2015-08-17 17:34 ` Pedro Alves
2015-08-13 12:45 ` [PATCH v2 3/3] gdb: Add debug tracing for bfd cache activity Andrew Burgess
2015-08-17 17:34 ` Pedro Alves [this message]
2015-08-13 12:45 ` [PATCH v2 2/3] gdb: New maintenance command to disable bfd sharing Andrew Burgess
2015-08-13 14:24 ` Eli Zaretskii
2015-08-17 17:34 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D21B2D.4090009@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox