Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make
Date: Wed, 16 Nov 2016 16:32:00 -0000	[thread overview]
Message-ID: <83mvgzfkrr.fsf@gnu.org> (raw)
In-Reply-To: <20161116160808.12830-3-simon.marchi@ericsson.com> (message from	Simon Marchi on Wed, 16 Nov 2016 11:08:06 -0500)

> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Wed, 16 Nov 2016 11:08:06 -0500
> 
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Since GNU make is now required to build GDB, we can remove everything
> that checks whether the current make implemention is the GNU one or
> not.  I simply removed the @GMAKE_TRUE@ prefixes and removed the whole
> lines that were prefixed with @GMAKE_FALSE@.

Since GDB is built by first running Make in sibling directories, which
don't require a GNU Make yet, what does this mean in case the user
runs a non-GNU Make?  Will they have strange errors half way through
the build?  Should we detect this early on and bail out?


  reply	other threads:[~2016-11-16 16:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 16:11 [PATCH 0/4] Require GNU make Simon Marchi
2016-11-16 16:10 ` [PATCH 4/4] Makefile: Replace explicit subdir rules with pattern rules Simon Marchi
2016-11-16 17:11   ` Pedro Alves
2016-11-16 16:12 ` [PATCH 2/4] Remove code that checks for GNU/non-GNU make Simon Marchi
2016-11-16 16:32   ` Eli Zaretskii [this message]
2016-11-16 16:39     ` Andreas Schwab
2016-11-16 17:12       ` Simon Marchi
2016-11-16 17:12       ` Pedro Alves
2016-11-16 17:09   ` Pedro Alves
2016-11-16 16:12 ` [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules Simon Marchi
2016-11-16 16:35   ` Eli Zaretskii
2016-11-16 16:56     ` Pedro Alves
2016-11-16 17:14       ` Eli Zaretskii
2016-11-16 17:32         ` Pedro Alves
2016-11-16 17:49           ` Eli Zaretskii
2016-11-16 17:58             ` Pedro Alves
2016-11-16 19:38       ` Simon Marchi
2016-11-16 19:58         ` Pedro Alves
2016-11-16 20:18           ` Simon Marchi
2016-11-16 19:11   ` Pedro Alves
2016-11-17 16:52     ` Simon Marchi
2016-11-17 16:57       ` Pedro Alves
2016-11-16 16:12 ` [PATCH 1/4] Document new hard requirement on GNU make Simon Marchi
2016-11-16 16:29   ` Eli Zaretskii
2016-11-16 17:05     ` Simon Marchi
2016-11-16 17:23       ` Eli Zaretskii
2016-11-16 22:05         ` Simon Marchi
2016-11-16 23:34           ` Pedro Alves
2016-11-17 12:39             ` Pedro Alves
2016-11-17 13:39               ` Simon Marchi
2016-11-17 16:10                 ` Eli Zaretskii
2016-11-17  3:35           ` Eli Zaretskii
2016-11-17 10:06             ` Jonas Maebe
2016-11-17 12:43               ` Pedro Alves
2016-11-17 17:05 ` [PATCH 0/4] Require " Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mvgzfkrr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox