Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Document new hard requirement on GNU make
Date: Wed, 16 Nov 2016 17:05:00 -0000	[thread overview]
Message-ID: <814e16be74a92751d1a2e47ba88b6ad9@polymtl.ca> (raw)
In-Reply-To: <83oa1ffkwa.fsf@gnu.org>

On 2016-11-16 11:29, Eli Zaretskii wrote:
> OK.
> 
> Should we decide which oldest version of GNU Make we are willing to
> support?  IOW, which features do we need for the build?
> 
> Thanks.

Probably, yes, but I'm not aware of the exact features/bugfix we have to 
rely on.  From what I can see, pattern rules have been around since 
forever (I checked out a commit of make from 1993, and it was already in 
the doc).  However, if there is a particular bug about pattern rules in 
some versions of make we want to avoid, I am not aware of it.

While trying to make GDBserver use pattern rules as well, I was reading 
this:

   
http://stackoverflow.com/questions/11455182/when-multiple-pattern-rules-match-a-target

I wanted to know which rule would get chosen if you wanted to build 
foo-ipa.o from foo-ipa.c, and you had the two rules:

%.o: %.c
   <generic compilation commands>

%-ipa.o: %-ipa.c
   <ipa-specific compilation commands>

With make >= 3.82, it would do the right thing (choose the second one), 
by choosing the rule with the shorter stem.  Before that, it used the 
order of definition (the first that matches wins).  So it would be nice 
for that reason to require >= 3.82, but it's also possible to work 
around if that's too recent.



  reply	other threads:[~2016-11-16 17:05 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 16:11 [PATCH 0/4] Require " Simon Marchi
2016-11-16 16:10 ` [PATCH 4/4] Makefile: Replace explicit subdir rules with pattern rules Simon Marchi
2016-11-16 17:11   ` Pedro Alves
2016-11-16 16:12 ` [PATCH 2/4] Remove code that checks for GNU/non-GNU make Simon Marchi
2016-11-16 16:32   ` Eli Zaretskii
2016-11-16 16:39     ` Andreas Schwab
2016-11-16 17:12       ` Simon Marchi
2016-11-16 17:12       ` Pedro Alves
2016-11-16 17:09   ` Pedro Alves
2016-11-16 16:12 ` [PATCH 1/4] Document new hard requirement on GNU make Simon Marchi
2016-11-16 16:29   ` Eli Zaretskii
2016-11-16 17:05     ` Simon Marchi [this message]
2016-11-16 17:23       ` Eli Zaretskii
2016-11-16 22:05         ` Simon Marchi
2016-11-16 23:34           ` Pedro Alves
2016-11-17 12:39             ` Pedro Alves
2016-11-17 13:39               ` Simon Marchi
2016-11-17 16:10                 ` Eli Zaretskii
2016-11-17  3:35           ` Eli Zaretskii
2016-11-17 10:06             ` Jonas Maebe
2016-11-17 12:43               ` Pedro Alves
2016-11-16 16:12 ` [PATCH 3/4] Makefile: Replace old suffix rules with pattern rules Simon Marchi
2016-11-16 16:35   ` Eli Zaretskii
2016-11-16 16:56     ` Pedro Alves
2016-11-16 17:14       ` Eli Zaretskii
2016-11-16 17:32         ` Pedro Alves
2016-11-16 17:49           ` Eli Zaretskii
2016-11-16 17:58             ` Pedro Alves
2016-11-16 19:38       ` Simon Marchi
2016-11-16 19:58         ` Pedro Alves
2016-11-16 20:18           ` Simon Marchi
2016-11-16 19:11   ` Pedro Alves
2016-11-17 16:52     ` Simon Marchi
2016-11-17 16:57       ` Pedro Alves
2016-11-17 17:05 ` [PATCH 0/4] Require GNU make Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=814e16be74a92751d1a2e47ba88b6ad9@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox