Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: phi.debian@gmail.com, tom@tromey.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add "set style tui-current-position on|off" default to off
Date: Tue, 16 Jun 2020 17:33:46 +0300	[thread overview]
Message-ID: <83mu5313n9.fsf@gnu.org> (raw)
In-Reply-To: <73b40c12-cbd2-336a-3258-96f5134843a3@redhat.com> (message from Pedro Alves via Gdb-patches on Tue, 16 Jun 2020 12:02:31 +0100)

> Date: Tue, 16 Jun 2020 12:02:31 +0100
> From: Pedro Alves via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tom@tromey.com>,
>  Pedro Alves via Gdb-patches <gdb-patches@sourceware.org>
> 
> gdb/ChangeLog:
> 
> 	* NEWS: Document that the TUI no longer styles the source code
> 	highlighted by the current position indicator by default.
> 	Mention "set style tui-current-position".
> 
> 	* cli/cli-style.c (style_set_list, style_show_list): Make extern.
> 	* gdbcmd.h (style_set_list, style_show_list): Declare.
> 	* tui/tui-io.c (apply_ansi_escape): Return early if styling the
> 	current position is disabled.
> 	(tui_set_reverse_mode): If reversing, and source styling for the
> 	current position is disabled, switch to default style, reversed.
> 	* tui/tui-win.c (style_tui_current_position)
> 	(show_style_tui_current_position, set_style_tui_current_position):
> 	New.
> 	(_initialize_tui_win): Install the "set/show style
> 	tui-current-position" commands.
> 	* tui/tui-win.h (style_tui_current_position): Declare.
> 
> gdb/doc/ChangeLog:
> 
> 	* gdb.texinfo (Output Styling): Document "set/show style
> 	tui-current-position".
> 	(TUI Overview): Document source code highlighting for the current
> 	position indicator and mention "set style tui-current-position
> 	off".

OK for the documentation parts.

Thanks.


  reply	other threads:[~2020-06-16 14:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  7:55 TUI enhancement suggestion Phi Debian
2020-06-09 13:04 ` Pedro Alves
2020-06-09 14:32   ` Phi Debian
2020-06-09 15:03     ` Phi Debian
2020-06-11 10:34       ` Pedro Alves
2020-06-11 13:55         ` Phi Debian
2020-06-15 14:20           ` Pedro Alves
2020-06-15 15:48             ` Hannes Domani
2020-06-15 16:56               ` Phi Debian
2020-06-15 19:30                 ` Pedro Alves
2020-06-15 19:47                   ` Phi Debian
2020-06-15 20:12                   ` Tom Tromey
2020-06-15 20:45                     ` Pedro Alves
2020-06-16  3:38                       ` Phi Debian
2020-06-16 11:02                         ` [PATCH] Add "set style tui-current-position on|off" default to off Pedro Alves
2020-06-16 14:33                           ` Eli Zaretskii [this message]
2022-11-15 10:09                           ` Andrew Burgess via Gdb-patches
2022-11-15 12:15                             ` Pedro Alves
2022-11-16 10:41                               ` Andrew Burgess via Gdb-patches
2022-11-17  6:30                                 ` Phi Debian via Gdb-patches
     [not found]   ` <CAJOr74jg==A7NM4qtWEq6neXqxpxxtUEVdDgsahfvRobW+Q0wA@mail.gmail.com>
     [not found]     ` <CAJOr74hQdi6Y4MpGy=J-3CTRA2PP08OebTO2hBFN5NyDRokb3Q@mail.gmail.com>
     [not found]       ` <CAJOr74gyyw4hJm9j0fzKQdzkJKzq=yiAXyZx_c2Q=RA8GTSN7Q@mail.gmail.com>
     [not found]         ` <ed9ea9c6-3d4d-6ba7-4672-bff2b2617012@redhat.com>
2020-06-10 20:25           ` TUI enhancement suggestion Phi Debian
2020-06-11 10:17             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mu5313n9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=phi.debian@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox