From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 85F76388C030 for ; Tue, 16 Jun 2020 14:34:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 85F76388C030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:57441) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlCf8-00011S-MG; Tue, 16 Jun 2020 10:34:06 -0400 Received: from [176.228.60.248] (port=4363 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlCf7-0004XS-Lo; Tue, 16 Jun 2020 10:34:06 -0400 Date: Tue, 16 Jun 2020 17:33:46 +0300 Message-Id: <83mu5313n9.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: phi.debian@gmail.com, tom@tromey.com, gdb-patches@sourceware.org In-Reply-To: <73b40c12-cbd2-336a-3258-96f5134843a3@redhat.com> (message from Pedro Alves via Gdb-patches on Tue, 16 Jun 2020 12:02:31 +0100) Subject: Re: [PATCH] Add "set style tui-current-position on|off" default to off References: <38b5d874-cdf2-50e7-dc76-aed3fee20334@redhat.com> <3011c306-2c6c-228f-07eb-95d3ff560942@redhat.com> <314644177.1902979.1592236099059@mail.yahoo.com> <07772538-b41f-49e2-43c9-c6cb8831050b@redhat.com> <87366whyvk.fsf@tromey.com> <00ed105b-6fe6-f554-f1d8-7f361695687e@redhat.com> <73b40c12-cbd2-336a-3258-96f5134843a3@redhat.com> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 14:34:08 -0000 > Date: Tue, 16 Jun 2020 12:02:31 +0100 > From: Pedro Alves via Gdb-patches > Cc: Tom Tromey , > Pedro Alves via Gdb-patches > > gdb/ChangeLog: > > * NEWS: Document that the TUI no longer styles the source code > highlighted by the current position indicator by default. > Mention "set style tui-current-position". > > * cli/cli-style.c (style_set_list, style_show_list): Make extern. > * gdbcmd.h (style_set_list, style_show_list): Declare. > * tui/tui-io.c (apply_ansi_escape): Return early if styling the > current position is disabled. > (tui_set_reverse_mode): If reversing, and source styling for the > current position is disabled, switch to default style, reversed. > * tui/tui-win.c (style_tui_current_position) > (show_style_tui_current_position, set_style_tui_current_position): > New. > (_initialize_tui_win): Install the "set/show style > tui-current-position" commands. > * tui/tui-win.h (style_tui_current_position): Declare. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Output Styling): Document "set/show style > tui-current-position". > (TUI Overview): Document source code highlighting for the current > position indicator and mention "set style tui-current-position > off". OK for the documentation parts. Thanks.