From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] traceframe_changed observer and MI notification
Date: Tue, 18 Sep 2012 08:01:00 -0000 [thread overview]
Message-ID: <83lig72206.fsf@gnu.org> (raw)
In-Reply-To: <50582156.50107@codesourcery.com>
> Date: Tue, 18 Sep 2012 15:23:02 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
>
> On 09/18/2012 02:52 PM, Eli Zaretskii wrote:
> >> +or @value{GDBN} stops examining traceframes and resumes live debugging.
> > This line should be edited to explain the meaning of negative values
> > of tfnum.
> >
>
> tfnum will never be negative in notification. In traceframe_changed
> observer, tfnum can be negative, and notification
> "=traceframe-changed,end" is emitted accordingly.
Then that line should be deleted.
> > Also, I don't understand the significance of the reference to
> > 'tfind'. Why is it important to mention that?
> >
>
> because users use command 'tfind' to examine a certain traceframe, and
> the changes of traceframe trigger this MI notification, so I mention
> 'tfind' here.
The text you wrote can be interpreted as if using 'tfind' was the only
way to change the trace frame. If that's not true, 'tfind' it should
be mentioned in parentheses, something like
(e.g., by using the @code{tfind} command)
next prev parent reply other threads:[~2012-09-18 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 9:10 Yao Qi
2012-09-07 6:59 ` [ping]: " Yao Qi
2012-09-10 18:52 ` Tom Tromey
2012-09-11 13:38 ` Yao Qi
2012-09-11 15:28 ` Tom Tromey
2012-09-18 0:09 ` Yao Qi
2012-09-18 6:53 ` Eli Zaretskii
2012-09-18 7:24 ` Yao Qi
2012-09-18 8:01 ` Eli Zaretskii [this message]
2012-09-18 8:48 ` Yao Qi
2012-09-18 9:42 ` Eli Zaretskii
2012-09-18 11:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lig72206.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox