From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18198 invoked by alias); 18 Sep 2012 08:01:39 -0000 Received: (qmail 18184 invoked by uid 22791); 18 Sep 2012 08:01:38 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Sep 2012 08:01:24 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MAJ00E00CRTOS00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 18 Sep 2012 11:01:22 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAJ00EQ2CY8B4I0@a-mtaout22.012.net.il>; Tue, 18 Sep 2012 11:01:20 +0300 (IDT) Date: Tue, 18 Sep 2012 08:01:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] traceframe_changed observer and MI notification In-reply-to: <50582156.50107@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83lig72206.fsf@gnu.org> References: <1346404195-20864-1-git-send-email-yao@codesourcery.com> <5057BB72.9070305@codesourcery.com> <83pq5j257w.fsf@gnu.org> <50582156.50107@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00346.txt.bz2 > Date: Tue, 18 Sep 2012 15:23:02 +0800 > From: Yao Qi > CC: > > On 09/18/2012 02:52 PM, Eli Zaretskii wrote: > >> +or @value{GDBN} stops examining traceframes and resumes live debugging. > > This line should be edited to explain the meaning of negative values > > of tfnum. > > > > tfnum will never be negative in notification. In traceframe_changed > observer, tfnum can be negative, and notification > "=traceframe-changed,end" is emitted accordingly. Then that line should be deleted. > > Also, I don't understand the significance of the reference to > > 'tfind'. Why is it important to mention that? > > > > because users use command 'tfind' to examine a certain traceframe, and > the changes of traceframe trigger this MI notification, so I mention > 'tfind' here. The text you wrote can be interpreted as if using 'tfind' was the only way to change the trace frame. If that's not true, 'tfind' it should be mentioned in parentheses, something like (e.g., by using the @code{tfind} command)