Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Siva Chandra <sivachandra@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFC - GDB Python API] New gdb.Architecture class
Date: Wed, 23 Jan 2013 15:59:00 -0000	[thread overview]
Message-ID: <83libjnb5d.fsf@gnu.org> (raw)
In-Reply-To: <CAGyQ6gwTY59xn-g13Fk_E6s8+RuNO=D2WEh3N70jRMtP5NmE7w@mail.gmail.com>

> Date: Wed, 23 Jan 2013 05:53:04 -0800
> From: Siva Chandra <sivachandra@google.com>
> Cc: gdb-patches@sourceware.org
> 
> Done in the attached patch.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -39,6 +39,12 @@ Lynx 178 PowerPC		powerpc-*-lynx*178
>  
>    ** Python 3 is now supported (in addition to Python 2.4 or later)
>  
> +  ** New class gdb.Architecture exposes GDB's internal representation
> +     of architecture in the Python API.
> +
> +  ** New method Frame.architecture returns the gdb.Architecture object
> +     corresponding to the frame's architecture.
> +
>  * New Python-based convenience functions:
>  
>    ** $_memeq(buf1, buf2, length)

This part is OK.

> +@defun Frame.architecture ()
> +Returns the @code{gdb.Architecture} object corresponding to the frame's
> +architecture. @xref{Architectures In Python}
                                               ^
Period is missing here.  Also, please leave 2 spaces between sentences
(here before the "@xref").

OK with that change.


  parent reply	other threads:[~2013-01-23 15:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 14:08 Siva Chandra
2013-01-21 17:09 ` Tom Tromey
2013-01-22 20:40   ` Siva Chandra
2013-01-22 21:17     ` Tom Tromey
2013-01-23 13:53       ` Siva Chandra
2013-01-23 15:35         ` Tom Tromey
2013-01-23 15:59         ` Eli Zaretskii [this message]
2013-01-23 21:01           ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83libjnb5d.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox