From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97925-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12229 invoked by alias); 23 Jan 2013 15:59:40 -0000
Received: (qmail 12218 invoked by uid 22791); 23 Jan 2013 15:59:38 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jan 2013 15:59:27 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MH3009005MQA300@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 23 Jan 2013 17:59:09 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MH3009685QKAC00@a-mtaout22.012.net.il>; Wed, 23 Jan 2013 17:59:08 +0200 (IST)
Date: Wed, 23 Jan 2013 15:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC - GDB Python API] New gdb.Architecture class
In-reply-to: <CAGyQ6gwTY59xn-g13Fk_E6s8+RuNO=D2WEh3N70jRMtP5NmE7w@mail.gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83libjnb5d.fsf@gnu.org>
References: <CAGyQ6gwAU-Qj-jkhj7gA7rG=xQOcZbp=g4Km8A3b6bLfsCWMqg@mail.gmail.com> <87sj5u31ku.fsf@fleche.redhat.com> <CAGyQ6gyWn4+W3ty56K6RASoKpRgmFQEt9crmYsUVYoVSkUK6tQ@mail.gmail.com> <87wqv4x6ib.fsf@fleche.redhat.com> <CAGyQ6gwTY59xn-g13Fk_E6s8+RuNO=D2WEh3N70jRMtP5NmE7w@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00555.txt.bz2

> Date: Wed, 23 Jan 2013 05:53:04 -0800
> From: Siva Chandra <sivachandra@google.com>
> Cc: gdb-patches@sourceware.org
> 
> Done in the attached patch.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -39,6 +39,12 @@ Lynx 178 PowerPC		powerpc-*-lynx*178
>  
>    ** Python 3 is now supported (in addition to Python 2.4 or later)
>  
> +  ** New class gdb.Architecture exposes GDB's internal representation
> +     of architecture in the Python API.
> +
> +  ** New method Frame.architecture returns the gdb.Architecture object
> +     corresponding to the frame's architecture.
> +
>  * New Python-based convenience functions:
>  
>    ** $_memeq(buf1, buf2, length)

This part is OK.

> +@defun Frame.architecture ()
> +Returns the @code{gdb.Architecture} object corresponding to the frame's
> +architecture. @xref{Architectures In Python}
                                               ^
Period is missing here.  Also, please leave 2 spaces between sentences
(here before the "@xref").

OK with that change.