Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA PATCH] Enable -Wpointer-sign by default.
Date: Sat, 20 Apr 2013 07:38:00 -0000	[thread overview]
Message-ID: <83li8e1j3q.fsf@gnu.org> (raw)
In-Reply-To: <20130419175932.13401.30699.stgit@brno.lan>

> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 19 Apr 2013 18:59:32 +0100
> 
> +@item -Wpointer-sign
> +This helps make sure @value{GDBN} code uses @code{gdb_byte} which is
> +really @code{unsigned char} for raw bytes instead of @code{char},
> +whose signness is host-dependent.  @sc{gcc} enables this with
> +@code{-Wall} since version 4.0.  We enable it explicitly too to be
> +decoupled from future @sc{gcc} (or other compiler)'s choices.

I'd use "defaults" instead of "choices".

As for "other compilers": do other compilers really have, or are
likely to have, options that are named like that?  If not, I suggest
to delete the part in the parentheses.

OK with those changes.

Thanks.


  reply	other threads:[~2013-04-19 18:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-20  7:04 Pedro Alves
2013-04-20  7:38 ` Eli Zaretskii [this message]
2013-04-21  2:18   ` Pedro Alves
2013-04-21  2:03 ` Tom Tromey
2013-04-21  4:59   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83li8e1j3q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox