From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100701-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28452 invoked by alias); 19 Apr 2013 18:17:07 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 28441 invoked by uid 89); 19 Apr 2013 18:17:07 -0000
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 18:17:06 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MLI00C00LB8F500@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 19 Apr 2013 21:16:53 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MLI00CCYLG5EO30@a-mtaout20.012.net.il>; Fri, 19 Apr 2013 21:16:53 +0300 (IDT)
Date: Sat, 20 Apr 2013 07:38:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA PATCH] Enable -Wpointer-sign by default.
In-reply-to: <20130419175932.13401.30699.stgit@brno.lan>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83li8e1j3q.fsf@gnu.org>
References: <20130419175932.13401.30699.stgit@brno.lan>
X-SW-Source: 2013-04/txt/msg00627.txt.bz2

> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 19 Apr 2013 18:59:32 +0100
> 
> +@item -Wpointer-sign
> +This helps make sure @value{GDBN} code uses @code{gdb_byte} which is
> +really @code{unsigned char} for raw bytes instead of @code{char},
> +whose signness is host-dependent.  @sc{gcc} enables this with
> +@code{-Wall} since version 4.0.  We enable it explicitly too to be
> +decoupled from future @sc{gcc} (or other compiler)'s choices.

I'd use "defaults" instead of "choices".

As for "other compilers": do other compilers really have, or are
likely to have, options that are named like that?  If not, I suggest
to delete the part in the parentheses.

OK with those changes.

Thanks.