From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Run catch-load.exp on Windows
Date: Thu, 12 Sep 2013 02:44:00 -0000 [thread overview]
Message-ID: <83li32iwrs.fsf@gnu.org> (raw)
In-Reply-To: <1378947563-26245-1-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 12 Sep 2013 08:59:23 +0800
>
> I find a compilation error when catch-load.c is compiled.
>
> catch-load.c:18:19: fatal error: dlfcn.h: No such file or directory
>
> This patch is to fix this compilation error. With this patch applied,
> test case can be compiled successfully. However, there is one fail
> caused by matching "/" in file name, which doesn't exist on Windows.
> This patch fixes it by matching either "/" or "\" in file name.
>
> gdb/testsuite:
>
> 2013-09-12 Yao Qi <yao@codesourcery.com>
>
> * gdb.base/catch-load.c: Remove the include of "dlfcn.h".
> [__WIN32__]: Include "windows.h" and define macro dlopen
> and dlclose.
> [!__WIN32__]: Include "dlfcn.h".
Isn't it better to create a new file gdb_dlfcn.h, and move all the
portability stuff there?
next prev parent reply other threads:[~2013-09-12 2:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 1:00 Yao Qi
2013-09-12 2:44 ` Eli Zaretskii [this message]
2013-09-12 11:38 ` Yao Qi
2013-09-12 15:36 ` Pierre Muller
2013-09-16 13:21 ` Yao Qi
2013-09-16 14:26 ` Pedro Alves
2013-09-16 16:24 ` Pierre Muller
[not found] ` <33630.1438547254$1379000229@news.gmane.org>
2013-09-17 18:39 ` Tom Tromey
2013-09-16 14:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83li32iwrs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox