From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-105221-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24763 invoked by alias); 12 Sep 2013 02:44:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24745 invoked by uid 89); 12 Sep 2013 02:44:54 -0000
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Sep 2013 02:44:54 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.2
X-HELO: mtaout20.012.net.il
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MSZ00300RBL9Z00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 12 Sep 2013 05:44:51 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MSZ003RWRMR2X50@a-mtaout20.012.net.il>; Thu, 12 Sep 2013 05:44:51 +0300 (IDT)
Date: Thu, 12 Sep 2013 02:44:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Run catch-load.exp on Windows
In-reply-to: <1378947563-26245-1-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83li32iwrs.fsf@gnu.org>
References: <1378947563-26245-1-git-send-email-yao@codesourcery.com>
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg00366.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 12 Sep 2013 08:59:23 +0800
> 
> I find a compilation error when catch-load.c is compiled.
> 
>  catch-load.c:18:19: fatal error: dlfcn.h: No such file or directory
> 
> This patch is to fix this compilation error.  With this patch applied,
> test case can be compiled successfully.  However, there is one fail
> caused by matching "/" in file name, which doesn't exist on Windows.
> This patch fixes it by matching either "/" or "\" in file name.
> 
> gdb/testsuite:
> 
> 2013-09-12  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.base/catch-load.c: Remove the include of "dlfcn.h".
> 	 [__WIN32__]: Include "windows.h" and define macro dlopen
> 	 and dlclose.
> 	[!__WIN32__]: Include "dlfcn.h".

Isn't it better to create a new file gdb_dlfcn.h, and move all the
portability stuff there?