Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
Date: Wed, 13 Jan 2016 16:09:00 -0000	[thread overview]
Message-ID: <83lh7tihpw.fsf@gnu.org> (raw)
In-Reply-To: <1452688799-15633-3-git-send-email-walfred.tedeschi@intel.com>	(message from Walfred Tedeschi on Wed, 13 Jan 2016 13:39:59 +0100)

> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Wed, 13 Jan 2016 13:39:59 +0100
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,10 @@
>  
>  *** Changes since GDB 7.10
>  
> +* show mpx-bnd-init-on-return
> +  set mpx-bnd-init-on-return on i386 and amd64
> +   Support for set bound registers to INIT state when using the command return.

Please quote "return" in the last sentence.

> +While the using the @command{return} bounds can propagate through
         ^^^
This "the" should be deleted.  Also, @command is for external
commands, not GDB commands.

> +execution causing a boundary violation.

Hmm... "propagate through execution" is not really clear.  How about
simplifying this, like below?

  When you use the @code{return} command, the bound registers might
  cause boundary violations because they were not updated for the
  early return from the function.

> +The behaviour of initializing bounds when using @command{return}
> +can be controlled and vizualized via the following commands:

I think we should explain how initializing these registers comes into
play.  Like this, for example:

  To countermand that, @value{GDBN} can force initialization of the
  bound registers when it performs the @code{return} command.  This is
  controlled by the following option:

The documentation parts are OK with these fixes.

Thanks.


  reply	other threads:[~2016-01-13 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 12:40 [PATCH V3 0/2] MPX ABI adaptations Walfred Tedeschi
2016-01-13 12:40 ` [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls Walfred Tedeschi
2016-01-13 16:09   ` Eli Zaretskii [this message]
2016-01-13 16:12     ` Tedeschi, Walfred
2016-02-02 16:47   ` Tedeschi, Walfred
2016-02-07  7:06   ` Joel Brobecker
2016-02-08 12:55     ` Walfred Tedeschi
2016-01-13 12:40 ` [PATCH V3 1/2] ABI changes for MPX Walfred Tedeschi
2016-01-13 15:59   ` Eli Zaretskii
2016-02-07  6:29   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lh7tihpw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox