From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35025 invoked by alias); 13 Jan 2016 16:09:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35016 invoked by uid 89); 13 Jan 2016 16:09:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=36, 3,10, simplifying, HX-Received-From:4830 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 13 Jan 2016 16:09:44 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJNzO-0002lm-C8 for gdb-patches@sourceware.org; Wed, 13 Jan 2016 11:09:43 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNzO-0002li-8v; Wed, 13 Jan 2016 11:09:38 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1608 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aJNzL-000342-Vh; Wed, 13 Jan 2016 11:09:37 -0500 Date: Wed, 13 Jan 2016 16:09:00 -0000 Message-Id: <83lh7tihpw.fsf@gnu.org> From: Eli Zaretskii To: Walfred Tedeschi CC: brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: <1452688799-15633-3-git-send-email-walfred.tedeschi@intel.com> (message from Walfred Tedeschi on Wed, 13 Jan 2016 13:39:59 +0100) Subject: Re: [PATCH V3 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls. Reply-to: Eli Zaretskii References: <1452688799-15633-1-git-send-email-walfred.tedeschi@intel.com> <1452688799-15633-3-git-send-email-walfred.tedeschi@intel.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00260.txt.bz2 > From: Walfred Tedeschi > Cc: gdb-patches@sourceware.org, Walfred Tedeschi > Date: Wed, 13 Jan 2016 13:39:59 +0100 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,10 @@ > > *** Changes since GDB 7.10 > > +* show mpx-bnd-init-on-return > + set mpx-bnd-init-on-return on i386 and amd64 > + Support for set bound registers to INIT state when using the command return. Please quote "return" in the last sentence. > +While the using the @command{return} bounds can propagate through ^^^ This "the" should be deleted. Also, @command is for external commands, not GDB commands. > +execution causing a boundary violation. Hmm... "propagate through execution" is not really clear. How about simplifying this, like below? When you use the @code{return} command, the bound registers might cause boundary violations because they were not updated for the early return from the function. > +The behaviour of initializing bounds when using @command{return} > +can be controlled and vizualized via the following commands: I think we should explain how initializing these registers comes into play. Like this, for example: To countermand that, @value{GDBN} can force initialization of the bound registers when it performs the @code{return} command. This is controlled by the following option: The documentation parts are OK with these fixes. Thanks.