Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: GDB 8.1.90 available for testing
Date: Tue, 31 Jul 2018 16:58:00 -0000	[thread overview]
Message-ID: <83lg9rnxzq.fsf@gnu.org> (raw)
In-Reply-To: <87tvohopcc.fsf@tromey.com> (message from Tom Tromey on Sun, 29	Jul 2018 12:42:59 -0600)

> From: Tom Tromey <tom@tromey.com>
> Cc: brobecker@adacore.com,  gdb-patches@sourceware.org
> Date: Sun, 29 Jul 2018 12:42:59 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> CXX    symfile.o
> >> symfile.c: In function 'void set_objfile_default_section_offset(objfile*, const section_addr_info&, CORE_ADDR)':
> >> symfile.c:2114:14: warning: types may not be defined in a for-range-declaration
> >> for (const struct other_sections *objf_sect : objf_addrs_sorted)
> >> ^~~~~~
> >> 
> >> The first two I saw in GDB 8.1 and reported back in January.  I
> >> believe the conclusion was that we disregard these warnings?
> >> 
> >> But what about the 3rd one?
> 
> I think this is a gcc bug.  This looks related:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79566
> 
> Simon occasionally fixes these by removing the 'struct' keyword.
> This seems fine since it isn't really inconvenient and people may be
> using the buggy versions of gcc.
> 
> This particular spot was fixed on git master in revision ff27d0737ef0.
> I think it would be fine to cherry-pick that to the branch.

Thanks, I've now cherry-picked that commit to the 8.2 branch.


      reply	other threads:[~2018-07-31 16:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 16:32 Joel Brobecker
2018-07-18 16:13 ` Eli Zaretskii
2018-07-19 14:37   ` Tom Tromey
2018-07-19 14:48     ` Eli Zaretskii
2018-07-29  2:37   ` Eli Zaretskii
2018-07-29 18:43     ` Tom Tromey
2018-07-31 16:58       ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lg9rnxzq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox