From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120181 invoked by alias); 31 Jul 2018 16:58:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120152 invoked by uid 89); 31 Jul 2018 16:58:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Jul 2018 16:58:13 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkXyK-0005M8-Hq for gdb-patches@sourceware.org; Tue, 31 Jul 2018 12:58:11 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkXyK-0005M4-DQ; Tue, 31 Jul 2018 12:58:08 -0400 Received: from [176.228.60.248] (port=4232 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fkXyJ-0001mB-SQ; Tue, 31 Jul 2018 12:58:08 -0400 Date: Tue, 31 Jul 2018 16:58:00 -0000 Message-Id: <83lg9rnxzq.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: <87tvohopcc.fsf@tromey.com> (message from Tom Tromey on Sun, 29 Jul 2018 12:42:59 -0600) Subject: Re: GDB 8.1.90 available for testing References: <20180704162202.C240286B57@joel.gnat.com> <83y3e834jw.fsf@gnu.org> <837eleu5q7.fsf@gnu.org> <87tvohopcc.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00826.txt.bz2 > From: Tom Tromey > Cc: brobecker@adacore.com, gdb-patches@sourceware.org > Date: Sun, 29 Jul 2018 12:42:59 -0600 > > >>>>> "Eli" == Eli Zaretskii writes: > > >> CXX symfile.o > >> symfile.c: In function 'void set_objfile_default_section_offset(objfile*, const section_addr_info&, CORE_ADDR)': > >> symfile.c:2114:14: warning: types may not be defined in a for-range-declaration > >> for (const struct other_sections *objf_sect : objf_addrs_sorted) > >> ^~~~~~ > >> > >> The first two I saw in GDB 8.1 and reported back in January. I > >> believe the conclusion was that we disregard these warnings? > >> > >> But what about the 3rd one? > > I think this is a gcc bug. This looks related: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79566 > > Simon occasionally fixes these by removing the 'struct' keyword. > This seems fine since it isn't really inconvenient and people may be > using the buggy versions of gcc. > > This particular spot was fixed on git master in revision ff27d0737ef0. > I think it would be fine to cherry-pick that to the branch. Thanks, I've now cherry-picked that commit to the 8.2 branch.