From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 6/9] Unify windows specifics into common/windows-hdep files
Date: Wed, 30 Mar 2011 21:00:00 -0000 [thread overview]
Message-ID: <83k4fgqtqp.fsf@gnu.org> (raw)
In-Reply-To: <00b101cbeed2$b5aa4990$20fedcb0$%muller@ics-cnrs.unistra.fr>
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 30 Mar 2011 14:05:06 +0200
>
> - cygwin_conv_to_win32_path (program, real_path);
> + windows_conv_path (WINDOWS_POSIX_TO_NATIVE_A, program, real_path,
> + MAXPATHLEN);
> program = real_path;
> #endif
>
> @@ -924,11 +929,7 @@ win32_add_one_solib (const char *name, CORE_ADDR
> load_addr)
> }
> #endif
>
> -#ifdef __CYGWIN__
> - cygwin_conv_to_posix_path (buf, buf2);
> -#else
> - strcpy (buf2, buf);
> -#endif
> + windows_conv_path (WINDOWS_NATIVE_A_TO_POSIX, buf, buf2, MAX_PATH + 1);
>
> loaded_dll (buf2, load_addr);
See my other mail: windows_conv_path can fail, but the code does not
check for errors, and bravely used the possibly invalid results.
next parent reply other threads:[~2011-03-30 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00b101cbeed2$b5aa4990$20fedcb0$%muller@ics-cnrs.unistra.fr>
2011-03-30 21:00 ` Eli Zaretskii [this message]
2011-03-31 13:58 ` Pierre Muller
2011-03-30 12:15 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k4fgqtqp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox