From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80094-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22222 invoked by alias); 30 Mar 2011 19:44:17 -0000
Received: (qmail 22213 invoked by uid 22791); 30 Mar 2011 19:44:17 -0000
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_CP
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Mar 2011 19:44:09 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LIV00700YPIRP00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 30 Mar 2011 21:43:44 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.47.180]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LIV0078PYST9O80@a-mtaout22.012.net.il>; Wed, 30 Mar 2011 21:43:44 +0200 (IST)
Date: Wed, 30 Mar 2011 21:00:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC 6/9] Unify windows specifics into common/windows-hdep files
In-reply-to: <00b101cbeed2$b5aa4990$20fedcb0$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83k4fgqtqp.fsf@gnu.org>
References: <00b101cbeed2$b5aa4990$20fedcb0$%muller@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg01207.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 30 Mar 2011 14:05:06 +0200
> 
> -  cygwin_conv_to_win32_path (program, real_path);
> +  windows_conv_path (WINDOWS_POSIX_TO_NATIVE_A, program, real_path,
> +		     MAXPATHLEN);
>    program = real_path;
>  #endif
>  
> @@ -924,11 +929,7 @@ win32_add_one_solib (const char *name, CORE_ADDR
> load_addr)
>      }
>  #endif
>  
> -#ifdef __CYGWIN__
> -  cygwin_conv_to_posix_path (buf, buf2);
> -#else
> -  strcpy (buf2, buf);
> -#endif
> +  windows_conv_path (WINDOWS_NATIVE_A_TO_POSIX, buf, buf2, MAX_PATH + 1);
>  
>    loaded_dll (buf2, load_addr);

See my other mail: windows_conv_path can fail, but the code does not
check for errors, and bravely used the possibly invalid results.