Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 12/12] btrace: Extend ptwrite event decoding.
Date: Tue, 15 Jun 2021 16:52:14 +0300	[thread overview]
Message-ID: <83k0mv44mp.fsf@gnu.org> (raw)
In-Reply-To: <ac11ed45d339483e8efee53d4c8f42af@intel.com> (felix.willgerodt@intel.com)

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "Metzger, Markus T" <markus.t.metzger@intel.com>,
> 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Tue, 15 Jun 2021 13:40:40 +0000
> 
> >> +@smallexample
> >> +@group
> >> +(gdb) python-interactive
> >> +>>> class my_listener(object):
> >> +...    def __init__(self):
> >> +...        self.variable = 0
> >> +...    def __call__(self, payload, ip):
> >> +...        if gdb.selected_thread().global_num == 1:
> >> +...            self.variable += 1
> >> +...            return "payload: @{@}, ip: @{:#x@}".format(self.variable, ip)
> 
> Eli> This line is too long for @smallexample, it will cause overful hbox in the
> Eli> printed version of the manual.
> 
> Are you sure? I can't find any overfull hbox message for this line in the output
> of 'make pdf' or the resulting gdb.log. When I shorten the line significantly
> and diff the output of 'make pdf' (and gdb.log) with the long version,
> I see no real difference. There are only underful messages for python.texi for me.

In general, any line longer than about 66 characters in @example and
76 in @smallexample are too long, AFAIR.

  reply	other threads:[~2021-06-15 13:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 14:54 [PATCH v2 05/12] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 06/12] python: Add clear() to gdb.Record Felix Willgerodt via Gdb-patches
2021-06-14 15:52   ` Eli Zaretskii via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 07/12] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt via Gdb-patches
2021-06-14 15:53   ` Eli Zaretskii via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 08/12] btrace, linux: Enable ptwrite packets Felix Willgerodt via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 09/12] btrace, python: Enable ptwrite listener registration Felix Willgerodt via Gdb-patches
2021-06-15 23:41   ` Lancelot SIX via Gdb-patches
2021-06-16  7:26     ` Willgerodt, Felix via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 10/12] btrace, python: Enable calling the ptwrite listener Felix Willgerodt via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 11/12] gdb, testsuite, lib: Add libipt version check Felix Willgerodt via Gdb-patches
2021-06-14 14:54 ` [PATCH v2 12/12] btrace: Extend ptwrite event decoding Felix Willgerodt via Gdb-patches
2021-06-15 11:50   ` Eli Zaretskii via Gdb-patches
2021-06-15 13:40     ` Willgerodt, Felix via Gdb-patches
2021-06-15 13:52       ` Eli Zaretskii via Gdb-patches [this message]
2021-06-14 15:51 ` [PATCH v2 05/12] python: Introduce gdb.RecordAuxiliary class Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0mv44mp.fsf@gnu.org \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=felix.willgerodt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox