From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wwN1FLuwyGAYaAAAWB0awg (envelope-from ) for ; Tue, 15 Jun 2021 09:52:59 -0400 Received: by simark.ca (Postfix, from userid 112) id 453B61F163; Tue, 15 Jun 2021 09:52:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A5831E813 for ; Tue, 15 Jun 2021 09:52:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BDE70385042E for ; Tue, 15 Jun 2021 13:52:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BDE70385042E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623765176; bh=SdC++yjD3uEoEwozijh1FLADdpZul8WuTURyI6EQhH0=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ip9fwxsULDrtDBYJ06e0Zwd+03OFc48Iy9hFCA2sBD/yl876Yxz9w5RPpA0AUdSu7 OYivbfPYV2nLeoAGI/PP2681Bg/VdJVKUseppatCjAZJraDUYrmT9xiIZmPAWIwmVI MAJESvVTqGFqlAyd/mJXvxLsVE8GbLwOfavXhaVg= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A3D303857023 for ; Tue, 15 Jun 2021 13:52:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3D303857023 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54152) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lt9UY-000202-Id; Tue, 15 Jun 2021 09:52:34 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1582 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lt9UI-0006xm-MQ; Tue, 15 Jun 2021 09:52:34 -0400 Date: Tue, 15 Jun 2021 16:52:14 +0300 Message-Id: <83k0mv44mp.fsf@gnu.org> To: "Willgerodt, Felix" In-Reply-To: (felix.willgerodt@intel.com) Subject: Re: [PATCH v2 12/12] btrace: Extend ptwrite event decoding. References: <20210614145411.689277-1-felix.willgerodt@intel.com> <20210614145411.689277-8-felix.willgerodt@intel.com> <83wnqv4a9z.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: "Willgerodt, Felix" > CC: "Metzger, Markus T" , > "gdb-patches@sourceware.org" > Date: Tue, 15 Jun 2021 13:40:40 +0000 > > >> +@smallexample > >> +@group > >> +(gdb) python-interactive > >> +>>> class my_listener(object): > >> +... def __init__(self): > >> +... self.variable = 0 > >> +... def __call__(self, payload, ip): > >> +... if gdb.selected_thread().global_num == 1: > >> +... self.variable += 1 > >> +... return "payload: @{@}, ip: @{:#x@}".format(self.variable, ip) > > Eli> This line is too long for @smallexample, it will cause overful hbox in the > Eli> printed version of the manual. > > Are you sure? I can't find any overfull hbox message for this line in the output > of 'make pdf' or the resulting gdb.log. When I shorten the line significantly > and diff the output of 'make pdf' (and gdb.log) with the long version, > I see no real difference. There are only underful messages for python.texi for me. In general, any line longer than about 66 characters in @example and 76 in @smallexample are too long, AFAIR.