From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 9/9] Unify windows specifics into common/windows-hdep files
Date: Wed, 30 Mar 2011 21:34:00 -0000 [thread overview]
Message-ID: <83ipv0qtl5.fsf@gnu.org> (raw)
In-Reply-To: <00ba01cbeed2$bbf50150$33df03f0$%muller@ics-cnrs.unistra.fr>
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 30 Mar 2011 14:05:17 +0200
>
> if (strcasecmp (buf, "ntdll.dll") == 0)
> {
> - GetSystemDirectory (buf, sizeof (buf));
> + GetSystemDirectoryA (buf, sizeof (buf));
This will be a problem if we ever support a _UNICODE build.
> + if (windows_conv_path (WINDOWS_POSIX_TO_NATIVE, exec_file, real_path,
> + __PMAX * sizeof (win_buf_t)) < 0)
> error (_("Error starting executable: %d"), errno);
But windows_conv_path never returns a negative value, it returns zero
if it fails.
Thanks.
next parent reply other threads:[~2011-03-30 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00ba01cbeed2$bbf50150$33df03f0$%muller@ics-cnrs.unistra.fr>
2011-03-30 21:34 ` Eli Zaretskii [this message]
2011-03-30 21:34 ` Pierre Muller
2011-03-30 12:15 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ipv0qtl5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox