From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80095-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23431 invoked by alias); 30 Mar 2011 19:47:39 -0000
Received: (qmail 23422 invoked by uid 22791); 30 Mar 2011 19:47:39 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Mar 2011 19:47:29 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LIV00700YS4S100@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Wed, 30 Mar 2011 21:47:03 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.47.180]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LIV007M1YYDSL00@a-mtaout22.012.net.il>; Wed, 30 Mar 2011 21:47:02 +0200 (IST)
Date: Wed, 30 Mar 2011 21:34:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC 9/9] Unify windows specifics into common/windows-hdep files
In-reply-to: <00ba01cbeed2$bbf50150$33df03f0$%muller@ics-cnrs.unistra.fr>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ipv0qtl5.fsf@gnu.org>
References: <00ba01cbeed2$bbf50150$33df03f0$%muller@ics-cnrs.unistra.fr>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg01208.txt.bz2

> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 30 Mar 2011 14:05:17 +0200
> 
>    if (strcasecmp (buf, "ntdll.dll") == 0)
>      {
> -      GetSystemDirectory (buf, sizeof (buf));
> +      GetSystemDirectoryA (buf, sizeof (buf));

This will be a problem if we ever support a _UNICODE build.

> +      if (windows_conv_path (WINDOWS_POSIX_TO_NATIVE, exec_file, real_path,
> +			     __PMAX * sizeof (win_buf_t)) < 0)
>  	error (_("Error starting executable: %d"), errno);

But windows_conv_path never returns a negative value, it returns zero
if it fails.

Thanks.