From: Eli Zaretskii <eliz@gnu.org>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: gdb-patches@sourceware.org, stan_shebs@mentor.com
Subject: Re: [PATCH] Add autoload-breakpoints [7/7] autoload-breakpoints doc
Date: Sat, 24 Mar 2012 13:58:00 -0000 [thread overview]
Message-ID: <83iphut82x.fsf@gnu.org> (raw)
In-Reply-To: <4F69B416.60606@mentor.com>
> Date: Wed, 21 Mar 2012 18:57:26 +0800
> From: Hui Zhu <hui_zhu@mentor.com>
> CC: <gdb-patches@sourceware.org>, <stan_shebs@mentor.com>
>
> I post a patch that updated according to your comments. Please help me
> review it.
Below.
> +Prior to @value{GDBN} connects to remote stub, some breakpoints might
> +have been already set in target, either by a prior GDB session or
^^^
@value{GDBN}
> +remote stub. We call these breakpoints as "auotload-breakpoints".
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
We call these breakpoints @dfn{auotload-breakpoints}.
> +We believe such reliable report is useful to GDB, and generalize it,
> +called "ReportAsync".
We call these asynchronous reports about changes in the remote-side
breakpoints @dfn{ReportAsync}.
> +The connection between "ReportAsync" and "autoload-breakpoints" is when
> +inferior/stub add/set/delete breakpoints, sends async report to GDB about
> +added/set/removed breakpoints.
This sentence adds nothing to what already has been said. Please
remove it.
> +how to handle the autoload-breakpints when @value{GDBN} connect to the stub.
^^^^^^^^^^
A typo.
> +@cindex Autoload-breakpoints Format
Lower-case "autoload" and "format", please.
> +this packet through reportAsync Packets.
^^^^^^^^^^^
"ReportAsync", with a capital R.
OK with these changes.
Thanks.
next prev parent reply other threads:[~2012-03-24 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 8:53 Hui Zhu
2012-03-17 10:45 ` Eli Zaretskii
2012-03-20 15:42 ` Hui Zhu
2012-03-20 17:36 ` Eli Zaretskii
2012-03-21 10:57 ` Hui Zhu
2012-03-24 13:58 ` Eli Zaretskii [this message]
2012-03-26 2:16 ` Hui Zhu
2012-03-31 6:01 ` Eli Zaretskii
2012-04-02 9:15 ` Hui Zhu
2012-03-19 4:04 ` Yao Qi
2012-03-20 15:47 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iphut82x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=stan_shebs@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox