From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89198-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20985 invoked by alias); 24 Mar 2012 13:58:01 -0000
Received: (qmail 20973 invoked by uid 22791); 24 Mar 2012 13:57:59 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Mar 2012 13:57:45 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M1E00K006O65I00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 24 Mar 2012 15:57:43 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.229.240.24]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M1E00KK56S62360@a-mtaout21.012.net.il>; Sat, 24 Mar 2012 15:57:43 +0200 (IST)
Date: Sat, 24 Mar 2012 13:58:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Add autoload-breakpoints [7/7] autoload-breakpoints doc
In-reply-to: <4F69B416.60606@mentor.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: gdb-patches@sourceware.org, stan_shebs@mentor.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iphut82x.fsf@gnu.org>
References: <4F6450FF.1070103@mentor.com> <83wr6j33u1.fsf@gnu.org> <4F68A53F.6040103@mentor.com> <83mx7b18g5.fsf@gnu.org> <4F69B416.60606@mentor.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00820.txt.bz2

> Date: Wed, 21 Mar 2012 18:57:26 +0800
> From: Hui Zhu <hui_zhu@mentor.com>
> CC: <gdb-patches@sourceware.org>, <stan_shebs@mentor.com>
> 
> I post a patch that updated according to your comments.  Please help me 
> review it.

Below.

> +Prior to @value{GDBN} connects to remote stub, some breakpoints might
> +have been already set in target, either by a prior GDB session or
                                                      ^^^
@value{GDBN}

> +remote stub.  We call these breakpoints as "auotload-breakpoints".
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  We call these breakpoints @dfn{auotload-breakpoints}.

> +We believe such reliable report is useful to GDB, and generalize it,
> +called "ReportAsync".

 We call these asynchronous reports about changes in the remote-side
 breakpoints @dfn{ReportAsync}.

> +The connection between "ReportAsync" and "autoload-breakpoints" is when
> +inferior/stub add/set/delete breakpoints, sends async report to GDB about
> +added/set/removed breakpoints.

This sentence adds nothing to what already has been said.  Please
remove it.

> +how to handle the autoload-breakpints when @value{GDBN} connect to the stub.
                              ^^^^^^^^^^
A typo.

> +@cindex Autoload-breakpoints Format

Lower-case "autoload" and "format", please.

> +this packet through reportAsync Packets.
                       ^^^^^^^^^^^
"ReportAsync", with a capital R.

OK with these changes.

Thanks.