Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
Subject: Re: [PATCH 4/4] compile: New 'compile print'
Date: Fri, 27 Mar 2015 07:18:00 -0000	[thread overview]
Message-ID: <83iodmnc18.fsf@gnu.org> (raw)
In-Reply-To: <20150326205752.28223.24230.stgit@host1.jankratochvil.net>

> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Phil Muldoon <pmuldoon@redhat.com>
> Date: Thu, 26 Mar 2015 21:57:52 +0100
> 
> It is planned the existing GDB command 'print' will be able to evaluate its
> expressions using the compiler.  There will be some option to choose between
> the existing GDB evaluation and the compiler evaluation.  But as an
> intermediate step this patch provides the expression printing feature as a new
> command.
> 
> I can imagine it could be also called 'maintenance compile print' as in the
> future one should be able to use its functionality by the normal 'print'
> command.

I suggest a different name for this command.  Unfortunately, "eval" is
already taken, but perhaps "parse" or "parse-eval"?  Or maybe a new
switch to "print"?  "compile print" sounds awkward and unintuitive to
me.

> +  add_cmd ("print", class_obscure, compile_print_command,
> +	   _("\
> +Evaluate a EXPR with the compiler and print result.\n\

Suggest to drop the "a" part, it just makes this sentence harder to
read.

> +The expression may be specified in one line, e.g.:\n\

"on the same line as the command" sounds more clear to me.

Otherwise, the documentation parts are OK.

Thanks.


  parent reply	other threads:[~2015-03-27  7:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 20:57 [PATCH 1/4] Code cleanup: Make parts of print_command_1 public Jan Kratochvil
2015-03-26 20:57 ` [PATCH 2/4] compile: Add new field scope_data Jan Kratochvil
2015-04-06 17:28   ` obsolete: " Jan Kratochvil
2015-03-26 20:57 ` [PATCH 3/4] compile: Constify some parameters Jan Kratochvil
2015-04-06 17:28   ` obsolete: " Jan Kratochvil
2015-03-26 20:58 ` [PATCH 4/4] compile: New 'compile print' Jan Kratochvil
2015-03-26 20:59   ` Jan Kratochvil
2015-03-27  7:18   ` Eli Zaretskii [this message]
2015-03-27  7:33     ` Jan Kratochvil
2015-03-27  7:41       ` Eli Zaretskii
2015-03-27  7:56         ` Phil Muldoon
2015-03-27  9:08           ` Eli Zaretskii
2015-03-27  9:10           ` Eli Zaretskii
2015-03-27  9:16             ` Jan Kratochvil
2015-03-27  9:56               ` Eli Zaretskii
2015-03-27 10:11                 ` Jan Kratochvil
2015-03-27 10:20                 ` Phil Muldoon
2015-03-27 13:09                   ` Eli Zaretskii
2015-03-27 10:24                 ` Jan Kratochvil
2015-03-27 13:12                   ` Eli Zaretskii
2015-04-05 17:01   ` cancel: " Jan Kratochvil
2015-04-06 17:29   ` obsolete: " Jan Kratochvil
2015-03-27 20:06 ` [PATCH 1/4] v2: Code cleanup: Make parts of print_command_1 public Jan Kratochvil
2015-04-06 17:27   ` obsolete: " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83iodmnc18.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox