From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78523 invoked by alias); 27 Mar 2015 07:18:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78507 invoked by uid 89); 27 Mar 2015 07:18:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Mar 2015 07:18:49 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NLV00D000B4YD00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 27 Mar 2015 10:18:46 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLV00D4J0B9W840@a-mtaout22.012.net.il>; Fri, 27 Mar 2015 10:18:46 +0300 (IDT) Date: Fri, 27 Mar 2015 07:18:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 4/4] compile: New 'compile print' In-reply-to: <20150326205752.28223.24230.stgit@host1.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com Reply-to: Eli Zaretskii Message-id: <83iodmnc18.fsf@gnu.org> References: <20150326205727.28223.54648.stgit@host1.jankratochvil.net> <20150326205752.28223.24230.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00880.txt.bz2 > From: Jan Kratochvil > Cc: Phil Muldoon > Date: Thu, 26 Mar 2015 21:57:52 +0100 > > It is planned the existing GDB command 'print' will be able to evaluate its > expressions using the compiler. There will be some option to choose between > the existing GDB evaluation and the compiler evaluation. But as an > intermediate step this patch provides the expression printing feature as a new > command. > > I can imagine it could be also called 'maintenance compile print' as in the > future one should be able to use its functionality by the normal 'print' > command. I suggest a different name for this command. Unfortunately, "eval" is already taken, but perhaps "parse" or "parse-eval"? Or maybe a new switch to "print"? "compile print" sounds awkward and unintuitive to me. > + add_cmd ("print", class_obscure, compile_print_command, > + _("\ > +Evaluate a EXPR with the compiler and print result.\n\ Suggest to drop the "a" part, it just makes this sentence harder to read. > +The expression may be specified in one line, e.g.:\n\ "on the same line as the command" sounds more clear to me. Otherwise, the documentation parts are OK. Thanks.