Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hannes Domani <ssbssa@yahoo.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Implement debugging of WOW64 processes in gdbserver
Date: Fri, 24 Apr 2020 19:26:51 +0300	[thread overview]
Message-ID: <83h7x8alys.fsf@gnu.org> (raw)
In-Reply-To: <20200424155944.17332-1-ssbssa@yahoo.de> (message from Hannes Domani via Gdb-patches on Fri, 24 Apr 2020 17:59:44 +0200)

> Date: Fri, 24 Apr 2020 17:59:44 +0200
> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> 
> +#ifdef __x86_64__
> +  if (wow64_process)
> +    ok = (*win32_EnumProcessModulesEx) (current_process_handle,
> +					DllHandle,
> +					sizeof (HMODULE),
> +					&cbNeeded,
> +					LIST_MODULES_32BIT);

If win32_EnumProcessModulesEx is a NULL point (i.e. its load from the
DLL failed, because we are on an older Windows version), the above
will segfault, no?  Do we want to support WOW64 debugging on systems
older than Vista?

Thanks.


  reply	other threads:[~2020-04-24 16:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200424155944.17332-1-ssbssa.ref@yahoo.de>
2020-04-24 15:59 ` Hannes Domani
2020-04-24 16:26   ` Eli Zaretskii [this message]
2020-04-26 16:53     ` Hannes Domani
2020-04-26 17:14       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h7x8alys.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ssbssa@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox